Fix labelIdentifierFieldMetadata creation for custom objects #8729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds validation and error handling for label identifier fields in custom objects, ensuring proper creation and association of label identifiers with object metadata.
- Added
INVALID_LABEL_IDENTIFIERexception code in/packages/twenty-server/src/engine/metadata-modules/object-metadata/object-metadata.exception.ts - Added validation check in
createOne()to ensure label identifier field exists usingCUSTOM_OBJECT_STANDARD_FIELD_IDS.name - Added automatic update of
labelIdentifierFieldMetadataIdafter object creation in/packages/twenty-server/src/engine/metadata-modules/object-metadata/object-metadata.service.ts - Implemented error handling to throw exception when label identifier field creation fails
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
| if (!labelIdentifierFieldMetadata) { | ||
| throw new ObjectMetadataException( | ||
| 'Label identifier field metadata not created properly', | ||
| ObjectMetadataExceptionCode.INVALID_LABEL_IDENTIFIER, |
There was a problem hiding this comment.
MISSING_CUSTOM_OBJECT_DEFAULT_LABEL_IDENTIFIER_FIELD
charlesBochet
approved these changes
Nov 26, 2024
Weiko
added a commit
that referenced
this pull request
Nov 26, 2024
## Context Following #8729 This command backfills missing labelIdentifier for custom objects
Weiko
deleted the
c--fix-label-identifier-creation-for-custom-objects
branch
Weiko
added a commit
that referenced
this pull request
Nov 26, 2024
## Context Following #8729 This command backfills missing labelIdentifier for custom objects
Weiko
added a commit
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.