Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gateway): update tokio-tungstenite to v0.20 #2300

Closed
wants to merge 1 commit into from
Closed

chore(gateway): update tokio-tungstenite to v0.20 #2300

wants to merge 1 commit into from

Conversation

dnaka91
Copy link
Contributor

@dnaka91 dnaka91 commented Dec 5, 2023

There has recently been a CVE for tungstenite which can be fixed by updating from v0.18 to the latest v0.20.1.

@github-actions github-actions bot added the c-gateway Affects the gateway crate label Dec 5, 2023
There has recently been a CVE for tungstenite which can be fixed by
updating from v0.18 to the latest v0.20.1.
@dnaka91
Copy link
Contributor Author

dnaka91 commented Dec 5, 2023

As I was just being made aware of in #2301, there is a next branch for the next breaking version of Twilight. Looking at it, I see that tokio-tungstenite seems to be replaced with tokio-websockets.

I assume this update isn't needed anymore then?

@Erk-
Copy link
Member

Erk- commented Dec 5, 2023

As I don't see it as breaking we could do this for the last version that we release with the changes that have accumulated. @Gelbpunkt What is your thought about it?

@Gelbpunkt
Copy link
Member

I didn't plan a new patch release before the next minor release (which I intend to do this December), so this is not a dependency update we should be making. tokio-tungstenite 0.20 uses a different version of rustls than 0.18, which is a crate that should definitely be avoided duplicating in the dependency tree and is a change too large for a patch release. See this comment for my rationale behind rejecting essentially the same PR (linked one and #2270).

@dnaka91
Copy link
Contributor Author

dnaka91 commented Dec 5, 2023

Thanks for the input, I'll close this then. Sorry that I didn't see the previous PR which did essentially the same 🙇‍♂️

@dnaka91 dnaka91 closed this Dec 5, 2023
@dnaka91 dnaka91 deleted the tokio-tungstenite-v0.20 branch December 5, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-gateway Affects the gateway crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants