build(gateway, http, lavalink)!: Rename native feature to native-tls #2308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gelbpunkt
added
c-http
Erk-
approved these changes
Jan 15, 2024
Gelbpunkt
changed the title
Gelbpunkt
force-pushed
the
rename-native-tls
branch
from
df05766 to
1f003ed
Compare
vilgotf
requested changes
Jan 16, 2024
Signed-off-by: Jens Reidel <[email protected]>
Gelbpunkt
force-pushed
the
rename-native-tls
branch
from
1f003ed to
baf39a6
Compare
Done. While I was at it, I replaced the mention of |
vilgotf
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nativename is very unconcise.nativewhat? CPU target? TLS implementation? Renaming it tonative-tlsmakes it more self-explanatory and users less prone to erraneously enabling two TLS features.