feat(model): Add various From implementations for CommandOptionValue #2413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-model
itohatweb
approved these changes
Jan 28, 2025
Erk-
force-pushed
the
erk/feat/model/add-from-impl-for-commandoptionvalue
branch
from
fc7aad5 to
e77b081
Compare
khionu
reviewed
Jan 30, 2025
|
|
||
| impl From<Id<GenericMarker>> for CommandOptionValue { | ||
| fn from(value: Id<GenericMarker>) -> Self { | ||
| CommandOptionValue::Mentionable(value) |
There was a problem hiding this comment.
It might be a good idea to exclude this one? Since things other than mentionables could be provided.
There was a problem hiding this comment.
Would you not always have the specific type in those cases, GenericMarker is not used that much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We skip a couple that I don't think makes sense (
Focused,SubCommand, andSubCommandGroup)Closes #2403