Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Php8.4 #834

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Php8.4 #834

wants to merge 5 commits into from

Conversation

phpfui
Copy link
Contributor

@phpfui phpfui commented Nov 22, 2024

Fixes

This PR makes the minimal changes needed to avoid depreciation messages for PHP 8.4. It does not contain any logic changes:

  • Removes E_STRING in tests/bootstrap.php
  • Add ? to parameter types that default to null
  • Make explict $value property in \Twilio\TwiML\GenericNode
  • Change assertObjectNotHasAttribute to assertObjectNotHasProperty for PHPUnit

All changes should be compatible with PHP 7.1, which is the lowest supported PHP version.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant