-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create tables with an explicit INTEGER PRIMARY KEY. #87
Conversation
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
==========================================
- Coverage 92.48% 92.36% -0.12%
==========================================
Files 106 108 +2
Lines 10413 10511 +98
Branches 838 847 +9
==========================================
+ Hits 9630 9709 +79
- Misses 623 640 +17
- Partials 160 162 +2
Continue to review full report at Codecov.
|
axiom/store.py
Outdated
@return: a typeID for the table; a new one if no table exists, or the | ||
existing one if the table was created by another Store object | ||
referencing this database. | ||
Just create the table for an Item subclass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nit-picky, I know, but most of the docstrings in Axiom are pretty good, so I'd like to see the usual epydoc (or sphinx or whatever is good these days) markup in here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch; it's a private method, but given that we're calling it from another "friend" module, it definitely deserves better documentation.
I pushed some documentation-type improvements. |
I'm doing some testing using large existing stores that I have lying around and I've picked up some corruption issues after VACUUMing. I'm still investigating, but we definitely shouldn't merge this yet. |
False alarm on the corruption, turned out to be an unrelated issue. However I would definitely still like to do more testing before landing this. |
I have one active mantissa project still running; I will try to find some time today to test it out against this PR. |
I finally got around to running this against an active mantissa project of mine; no issues to report. |
f1fd411
to
753d923
Compare
After manually fixing up some schema issues (types defined in the database but not the code), I was able to do this upgrade successfully in one of my test environments and the data seems intact. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is kind of amazing to see.
It looks correct to me, and I think the proof is in the pudding with respect to your vacuum testing.
Please land.
Closes #35.