Cleanup some dependencies in tox.ini targets on Python versions #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* apidocs must run only on Python 2, because epydoc and pydoctor do not work on Python 3, so add a clarifying comment * manifest-checker, pycodestyle, pycodestylediff work on Python 2 or 3, so remove basepython from their targets * twistedchecker doesn't work on Python 3.6, and must be on Python 3.5, so change basepython version accordingly
rodrigc
changed the title
markrwilliams
approved these changes
Mar 24, 2018
| skip_install = true | ||
|
|
||
| # TwistedChecker needs to be 3.5 |
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## trunk #977 +/- ##
==========================================
+ Coverage 91.72% 92% +0.28%
==========================================
Files 843 844 +1
Lines 149350 155196 +5846
Branches 13076 14003 +927
==========================================
+ Hits 136986 142793 +5807
- Misses 10250 10292 +42
+ Partials 2114 2111 -3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://twistedmatrix.com/trac/ticket/9394
so add a clarifying comment
from their targets
version accordingly