Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twistedchecker fails on Python 3.6 #130

Open
rodrigc opened this issue Aug 21, 2017 · 1 comment
Open

twistedchecker fails on Python 3.6 #130

rodrigc opened this issue Aug 21, 2017 · 1 comment

Comments

@rodrigc
Copy link
Contributor

rodrigc commented Aug 21, 2017

twistedchecker cannot run on Python 3.6
This must remain on Python 3.5.
If you look at the logs: https://travis-ci.org/twisted/twisted/jobs/261731629 , this error is there:

AttributeError: 'TreeRebuilder3k' object has no attribute 'visit_joinedstr'

This is fixed upstream in newer versions of pylint and astroid: pylint-dev/pylint#1113

However, twistedchecker cannot use these new versions, because it monkey patches some internals
of astroid. So we need to keep the twistedchecker stuff on Python 3.5 for now,
until we can update twistedchecker to work with newer versions of astroid.

@rodrigc
Copy link
Contributor Author

rodrigc commented Aug 21, 2017

The modifiedBlankLines() function in twistedchecker https://github.com/twisted/twistedchecker/blob/master/twistedchecker/checkers/pycodestyleformat.py#L218
monkeypatches the blank_lines() function in pycodestyle: https://github.com/PyCQA/pycodestyle/blob/master/pycodestyle.py#L302

The problem is, the newer version of pycodesyle uses a function which takes 9 arguments,
but twistedchecker's function takes 7 arguments.

So this patch no longer works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant