Merge pull request #735 from twmb/example-messup

eos example: avoid short-circuit logic
twmb · May 23, 2024 · 2bc29e6 · 2bc29e6
2 parents c77d58e + 0574d20
commit 2bc29e6
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/examples/transactions/eos/main.go b/examples/transactions/eos/main.go
@@ -75,7 +75,8 @@ func inputProducer() {
 		for i := 0; i < 10; i++ {
 			cl.Produce(ctx, kgo.StringRecord(msg+strconv.Itoa(i)), e.Promise())
 		}
-		commit := kgo.TransactionEndTry(doCommit && e.Err() == nil)
+		perr := e.Err() // always evaluate e.Err() to ensure we do not short circuit in the logic below (doCommit && ... would fail if doCommit is false!)
+		commit := kgo.TransactionEndTry(doCommit && perr == nil)
 
 		switch err := cl.EndTransaction(ctx, commit); err {
 		case nil: