Skip to content

Commit

Permalink
kip-890 definitions
Browse files Browse the repository at this point in the history
A bunch of version bumps to indicate TransactionAbortable is supported
as an error return.
  • Loading branch information
twmb committed Oct 11, 2024
1 parent b66ceb7 commit 88ce9e9
Show file tree
Hide file tree
Showing 8 changed files with 21 additions and 21 deletions.
2 changes: 1 addition & 1 deletion generate/definitions/00_produce
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// Note that the special client ID "__admin_client" will allow you to produce
// records to internal topics. This is generally recommended if you want to
// break your Kafka cluster.
ProduceRequest => key 0, max version 10, flexible v9+
ProduceRequest => key 0, max version 11, flexible v9+
// TransactionID is the transaction ID to use for this request, allowing for
// exactly once semantics.
TransactionID: nullable-string // v3+
Expand Down
2 changes: 1 addition & 1 deletion generate/definitions/10_find_coordinator
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// This coordinator is different from the broker leader coordinator. This
// coordinator is the partition leader for the partition that is storing
// the group or transaction ID.
FindCoordinatorRequest => key 10, max version 4, flexible v3+
FindCoordinatorRequest => key 10, max version 5, flexible v3+
// CoordinatorKey is the ID to use for finding the coordinator. For groups,
// this is the group name, for transactional producer, this is the
// transactional ID.
Expand Down
2 changes: 1 addition & 1 deletion generate/definitions/22_init_producer_id
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
//
// Note that you do not need to go to a txn coordinator if you are initializing
// a producer id without a transactional id.
InitProducerIDRequest => key 22, max version 4, flexible v2+, txn coordinator
InitProducerIDRequest => key 22, max version 5, flexible v2+, txn coordinator
// TransactionalID is the ID to use for transactions if using transactions.
TransactionalID: nullable-string
// TransactionTimeoutMillis is how long a transaction is allowed before
Expand Down
2 changes: 1 addition & 1 deletion generate/definitions/24_add_partitions_to_txn
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
//
// Version 4 adds VerifyOnly field to check if partitions are already in
// transaction and adds support to batch multiple transactions.
AddPartitionsToTxnRequest => key 24, max version 4, flexible v3+, txn coordinator
AddPartitionsToTxnRequest => key 24, max version 5, flexible v3+, txn coordinator
// TransactionalID is the transactional ID to use for this request.
TransactionalID: string // v0-v3
// ProducerID is the producer ID of the client for this transactional ID
Expand Down
2 changes: 1 addition & 1 deletion generate/definitions/25_add_offsets_to_txn
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// Internally, this request simply adds the __consumer_offsets topic as a
// partition for this transaction with AddPartitionsToTxn for the partition
// in that topic that contains the group.
AddOffsetsToTxnRequest => key 25, max version 3, flexible v3+, txn coordinator
AddOffsetsToTxnRequest => key 25, max version 4, flexible v3+, txn coordinator
// TransactionalID is the transactional ID to use for this request.
TransactionalID: string
// ProducerID is the producer ID of the client for this transactional ID
Expand Down
2 changes: 1 addition & 1 deletion generate/definitions/26_end_txn
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// EndTxnRequest ends a transaction. This should be called after
// TxnOffsetCommitRequest.
EndTxnRequest => key 26, max version 3, flexible v3+, txn coordinator
EndTxnRequest => key 26, max version 4, flexible v3+, txn coordinator
// TransactionalID is the transactional ID to use for this request.
TransactionalID: string
// ProducerID is the producer ID of the client for this transactional ID
Expand Down
2 changes: 1 addition & 1 deletion generate/definitions/28_txn_offset_commit
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// TxnOffsetCommitRequest sends offsets that are a part of this transaction
// to be committed once the transaction itself finishes. This effectively
// replaces OffsetCommitRequest for when using transactions.
TxnOffsetCommitRequest => key 28, max version 3, flexible v3+, group coordinator
TxnOffsetCommitRequest => key 28, max version 4, flexible v3+, group coordinator
// TransactionalID is the transactional ID to use for this request.
TransactionalID: string
// Group is the group consumed in this transaction and to be used for
Expand Down
28 changes: 14 additions & 14 deletions pkg/kmsg/generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 88ce9e9

Please sign in to comment.