fix setting lz4 compression levels

twmb · Jul 17, 2024 · d7ea2c3 · d7ea2c3
1 parent a5f2b71
commit d7ea2c3
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 5 deletions.
diff --git a/pkg/kgo/compression.go b/pkg/kgo/compression.go
@@ -41,7 +41,7 @@ const (
 // for that batch.
 type CompressionCodec struct {
 	codec codecType
-	level int8
+	level int
 }
 
 // NoCompression is a compression option that avoids compression. This can
@@ -68,10 +68,7 @@ func ZstdCompression() CompressionCodec { return CompressionCodec{codecZstd, 0}
 //
 // If the level is invalid, compressors just use a default level.
 func (c CompressionCodec) WithLevel(level int) CompressionCodec {
-	if level > 127 {
-		level = 127 // lz4 could theoretically be large, I guess
-	}
-	c.level = int8(level)
+	c.level = level
 	return c
 }
 

diff --git a/pkg/kgo/compression_test.go b/pkg/kgo/compression_test.go
@@ -7,8 +7,22 @@ import (
 	"reflect"
 	"sync"
 	"testing"
+
+	"github.com/pierrec/lz4/v4"
 )
 
+// Regression test for #778.
+func TestCompressionCodecLZ4WithSpecifiedLevel(t *testing.T) {
+	t.Parallel()
+
+	codec := Lz4Compression().WithLevel(512)
+	w := lz4.NewWriter(new(bytes.Buffer))
+	err := w.Apply(lz4.CompressionLevelOption(lz4.CompressionLevel(codec.level)))
+	if err != nil {
+		t.Errorf("unexpected error: %v", err)
+	}
+}
+
 func TestNewCompressor(t *testing.T) {
 	t.Parallel()
 	for i, test := range []struct {