Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sticky: further improvements #612

Merged
merged 1 commit into from
Nov 1, 2023
Merged

sticky: further improvements #612

merged 1 commit into from
Nov 1, 2023

Conversation

twmb
Copy link
Owner

@twmb twmb commented Oct 31, 2023

  • Introduces separate functions for go 1.21+, allowing to eliminate unremoveable allocs from sort.Sort. To keep it simple, this simplifies <=1.20 a little bit, so that is slightly more inefficient.
  • Improves new-partition assignment further -- ensure we always place unassigned partitions on the least consuming member.

@twmb
sticky: further improvements
36b4437 
* Introduces separate functions for go 1.21+, allowing to eliminate
  unremoveable allocs from sort.Sort. To keep it simple, this simplifies
  <=1.20 a little bit, so that is **slightly** more inefficient.
* Improves new-partition assignment further -- ensure we always place
  unassigned partitions on the least consuming member.
@twmb twmb merged commit 3c628d5 into master Nov 1, 2023
4 of 6 checks passed
@twmb twmb deleted the sticky branch November 1, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@twmb