Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimisation: avoid ReadAll and use bytes buffer instead #629

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

kalbhor
Copy link
Contributor

@kalbhor kalbhor commented Dec 4, 2023

This PR helps resolve #623

@twmb
Copy link
Owner

twmb commented Dec 4, 2023

lgtm, mind squashing these commits?

@kalbhor
Copy link
Contributor Author

kalbhor commented Dec 5, 2023

Done 👍

@twmb twmb merged commit e737c90 into twmb:master Dec 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lz4 decompression causes a lot of allocations due to ioutil.ReadAll
2 participants