Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/kgo: use codecType explicitly #697

Merged
merged 1 commit into from
May 26, 2024

Conversation

cristaloleg
Copy link
Contributor

Scrolling through code I found mysterious constants, looks like this should be codecType.

However, codec param is byte but codecType is uint8 I don't think it's a problem. Changing function param will increase diff for no big reason.

Thanks for the franz-go BTW ;)

@twmb twmb added the minor label Mar 26, 2024
@twmb twmb mentioned this pull request Mar 26, 2024
12 tasks
@twmb
Copy link
Owner

twmb commented May 26, 2024

Sorry for the delay, the last few months were much busier than anticipated. Releasing imminently!

@twmb twmb removed the minor label May 26, 2024
@twmb twmb merged commit 48855f9 into twmb:master May 26, 2024
2 of 3 checks passed
@cristaloleg cristaloleg deleted the use-codectype-explicitly branch May 26, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants