Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eos example: avoid short-circuit logic #735

Merged
merged 1 commit into from
May 23, 2024
+2 −1
Merged

eos example: avoid short-circuit logic #735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion examples/transactions/eos/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ func inputProducer() {
for i := 0; i < 10; i++ {
cl.Produce(ctx, kgo.StringRecord(msg+strconv.Itoa(i)), e.Promise())
}
commit := kgo.TransactionEndTry(doCommit && e.Err() == nil)
perr := e.Err() // always evaluate e.Err() to ensure we do not short circuit in the logic below (doCommit && ... would fail if doCommit is false!)
commit := kgo.TransactionEndTry(doCommit && perr == nil)

switch err := cl.EndTransaction(ctx, commit); err {
case nil:
Expand Down
Loading