kgo: avoid / wakeup lingering if we hit max bytes or max records #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if your linger is long and your max records small, it is possible to linger even if the client cannot buffer any more records. Now, once max records or bytes is hit, we wakeup anything lingering and avoid entering the linger state again -- until we are no longer over max. Closes #726.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if your linger is long and your max records small, it is possible to linger even if the client cannot buffer any more records.
Now, once max records or bytes is hit, we wakeup anything lingering and avoid entering the linger state again -- until we are no longer over max.
Closes #726.