kgo.Offset: add AtCommitted() #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an Offset method that allows ConsumeResetOffset to exactly mirror Kafka's auto.offset.reset = none
Used to test the prior commit
Previously, if a topic had commits but some partitions in it did not, then Lag would do the CORRECT thing and show -1 for partitions that did not have a commit. What was NOT correct was that if an ENTIRE topic had no commits, then Lag would show the commit as 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an Offset method that allows ConsumeResetOffset to exactly
mirror Kafka's auto.offset.reset = none
Closes #692