Skip to content
This repository has been archived by the owner on Mar 22, 2023. It is now read-only.

Added service scaling state to the show CLI command #1675

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

derik01
Copy link
Collaborator

@derik01 derik01 commented Oct 24, 2022

Changes proposed in this PR

Why are we making these changes?

Add service state to show CLI command

@derik01 derik01 added the capstone-2022 Capstone Project label Oct 24, 2022
@shamsimam
Copy link
Contributor

shamsimam commented Oct 24, 2022

Some tests are still failing:

_____ MultiWaiterCliTest.test_show_multiple_cluster_groups_enforce_cluster _____
[gw4] linux -- Python 3.6.15 /opt/hostedtoolcache/Python/3.6.15/x64/bin/python

self = <tests.waiter.test_cli_multi_cluster.MultiWaiterCliTest testMethod=test_show_multiple_cluster_groups_enforce_cluster>

    def test_show_multiple_cluster_groups_enforce_cluster(self):
>       self.__test_show_multiple_cluster_groups(enforce_cluster=True)

tests/waiter/test_cli_multi_cluster.py:196: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
tests/waiter/test_cli_multi_cluster.py:179: in __test_show_multiple_cluster_groups
    self.assertIsNotNone(re.search(f'^{service_id_1}\\s+waiter1[^\\n]+Running[^\\n]+Current$', cli.stdout(cp), re.MULTILINE))
E   AssertionError: unexpectedly None
...
-- Docs: https://docs.pytest.org/en/latest/warnings.html
====== 3 failed, 203 passed, 2 xpassed, 30 warnings in 207.47s (0:03:27) =======

https://github.com/twosigma/waiter/actions/runs/3309218681/jobs/5462181622

@derik01 derik01 force-pushed the add-service-scaling-state branch from 94df609 to 6393bf4 Compare October 28, 2022 00:29
@shamsimam shamsimam merged commit bb63cee into master Oct 28, 2022
@shamsimam shamsimam deleted the add-service-scaling-state branch January 15, 2023 08:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
capstone-2022 Capstone Project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants