-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NonceGenerator trait and implement RollingNonce #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewWestberg
force-pushed
the
amw/epoch_nonce_generator
branch
2 times, most recently
from
August 14, 2024 01:39
ceeec1a
to
9e88da9
Compare
AndrewWestberg
force-pushed
the
amw/epoch_nonce_generator
branch
3 times, most recently
from
August 26, 2024 12:45
f82bc46
to
2e2bbd0
Compare
AndrewWestberg
force-pushed
the
amw/epoch_nonce_generator
branch
24 times, most recently
from
September 5, 2024 17:28
8916de9
to
20ecf3a
Compare
scarmuega
reviewed
Sep 13, 2024
NicolasDP
reviewed
Sep 13, 2024
AndrewWestberg
force-pushed
the
amw/epoch_nonce_generator
branch
7 times, most recently
from
September 15, 2024 23:28
6a64997
to
8591976
Compare
NicolasDP
reviewed
Sep 16, 2024
NicolasDP
reviewed
Sep 16, 2024
NicolasDP
reviewed
Sep 16, 2024
AndrewWestberg
force-pushed
the
amw/epoch_nonce_generator
branch
4 times, most recently
from
September 17, 2024 22:52
cb3cf1a
to
2246362
Compare
NicolasDP
previously approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just last two comments (that should be able to be added via the GitHub API if you wish to add them in). Otherwise I give my stamp of approval 🥇 .
Thanks so much for this great contribution to the pallas -- and to the Cardano Rust -- ecosystem.
AndrewWestberg
force-pushed
the
amw/epoch_nonce_generator
branch
from
September 25, 2024 16:27
fa8b497
to
471eba3
Compare
AndrewWestberg
force-pushed
the
amw/epoch_nonce_generator
branch
4 times, most recently
from
September 25, 2024 20:33
5764fdc
to
3be9e7e
Compare
AndrewWestberg
force-pushed
the
amw/epoch_nonce_generator
branch
from
September 25, 2024 20:43
3be9e7e
to
5fa60aa
Compare
NicolasDP
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rolling nonce on cardano is calculated for each block. It starts at the shelley genesis hash and applies each block's eta_vrf_0 value to the previous nonce and re-hashing.
Eventually, some of these rolling nonce values are used in the calculation of the epoch nonce which is required for consensus leadership checks.