Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor bats test #28

Merged
merged 7 commits into from
Jun 18, 2024
Merged

refactor bats test #28

merged 7 commits into from
Jun 18, 2024

Conversation

tyler36
Copy link
Owner

@tyler36 tyler36 commented Jul 5, 2023

This PR updates the addon's main tests.

Previously, we simple checked if Cypress could report its version number (although we didn't care what it was).

This PR refactors the test to:

  • Serve a HTML page via DDEV
  • Run cypress to confirm it can load and read the page.

This acts as a "real" test by actually using Cypress and supplying an example use that others can follow.

@tyler36 tyler36 force-pushed the improve_tests branch 4 times, most recently from 78fd124 to e174550 Compare July 7, 2023 02:15
@tyler36 tyler36 mentioned this pull request Sep 21, 2023
@tyler36
Copy link
Owner Author

tyler36 commented Sep 21, 2023

rebased

@tyler36 tyler36 merged commit 329e7c5 into main Jun 18, 2024
4 checks passed
@tyler36 tyler36 deleted the improve_tests branch June 18, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant