Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update .scalafmt.conf. enforce new wildcard syntax #4236

Merged
merged 1 commit into from
Jan 14, 2025
Merged

update .scalafmt.conf. enforce new wildcard syntax #4236

merged 1 commit into from
Jan 14, 2025

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Jan 13, 2025

No description provided.

@xuwei-k xuwei-k marked this pull request as ready for review January 13, 2025 11:32
djspiewak
djspiewak reviewed Jan 13, 2025
View reviewed changes
Copy link
Member

@djspiewak djspiewak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good but would you mind retargeting against series/3.6.x? It touches enough lines that we're going to need to have it on both branches.

@xuwei-k xuwei-k force-pushed the scalafmt-new-syntax branch from aca1704 to 03a16e7 Compare January 13, 2025 22:42
@xuwei-k xuwei-k changed the base branch from series/3.x to series/3.6.x January 13, 2025 22:43
@armanbilge armanbilge closed this Jan 14, 2025
@armanbilge armanbilge reopened this Jan 14, 2025
@xuwei-k

This comment was marked as resolved.

Sign in to view
@xuwei-k xuwei-k force-pushed the scalafmt-new-syntax branch from 03a16e7 to 20f8898 Compare January 14, 2025 02:18
djspiewak
djspiewak approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@djspiewak djspiewak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@djspiewak djspiewak merged commit 50d0708 into typelevel:series/3.6.x Jan 14, 2025
29 of 33 checks passed
@xuwei-k xuwei-k deleted the scalafmt-new-syntax branch January 17, 2025 22:13
@xuwei-k xuwei-k mentioned this pull request Jan 17, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djspiewak djspiewak djspiewak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xuwei-k @djspiewak @armanbilge