-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add flake #102
chore: add flake #102
Conversation
👷 Deploy request for merry-cranachan-ee7f1c pending review.Visit the deploys page to approve it
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on making your first PR and thank you for contributing to TypeStream! 🎉 ❤️
We hope to see you in our discord community too!
@lucapette What do you think? Only change is the |
Hi, I just want to draw your attention to the fact that I think that your kotlin/java dependencies are not managed by nix with this approach. This comment gives more context. The only locked dependencies are the |
@adfaure first of all, thank you for your work on this! Second off, I can't comment on flake/nix as I don't actually know what they are. As for the change in the script, I wouldn't want to do that as that's now how you'd want to use gradle in a project. The "gradle wrapper" ( I updated the script in #103 this morning so that the build images script uses the absolute path when calling gradle (basically removing the constraint that you have to run the build images script from the root of the repo). |
@lucapette I understand, I removed the gradle changes in the build script. It still works with your new script. @jevy could you confirm please? Regards |
@adfaure thank you very much for taking care of this. I will be adding notes about this in the docs after we merge |
PR: Add Flake for Development Environment in NixOS
Description
This PR introduces a flake to facilitate development within a NixOS environment.
To utilize this enhancement, ensure you have Nix installed with the flake feature enabled. Detailed instructions can be found here.
Once installed, navigate to the root of the project and execute
nix develop
. This command will drop you into a new shell equipped with the necessary Java dependency. I encountered no issues when following the command described in the contributing guide.Additionally, this PR includes a modification to use
gradle
instead ofgradlew
in the build-images.sh script, asgradlew
was not accessible in my path.