Implement new Java 21 features in dataflow #6192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h-clean-wpiplumelib into jdk21-test
smillst
commented
Sep 26, 2023
checker/src/main/java/org/checkerframework/checker/fenum/FenumAnnotatedTypeFactory.java
Outdated
Show resolved
Hide resolved
checker/src/main/java/org/checkerframework/checker/interning/InterningVisitor.java
Outdated
Show resolved
Hide resolved
| AnnotatedDeclaredType declaredType = (AnnotatedDeclaredType) varType; | ||
| for (AnnotatedTypeMirror atm : declaredType.getTypeArguments()) { | ||
| if (atm.hasPrimaryAnnotation(Unique.class)) { | ||
| } else if (tree.getType() != null) { |
There was a problem hiding this comment.
I went ahead and documented it everywhere.
…k into no-crash-jep440
This reverts commit bc9a755.
mernst
previously approved these changes
Sep 27, 2023
dataflow/src/main/java/org/checkerframework/dataflow/cfg/builder/CFGTranslationPhaseOne.java
Outdated
Show resolved
Hide resolved
javacutil/src/main/java/org/checkerframework/javacutil/TreeUtils.java
Outdated
Show resolved
Hide resolved
javacutil/src/main/java/org/checkerframework/javacutil/TreeUtils.java
Outdated
Show resolved
Hide resolved
…k into no-crash-jep440
This reverts commit 285bd8c.
|
@mernst Could you please re-review? I had to make more changes because I didn't realize that |
|
If this change is ready to go, it'd be helpful to NullAway if it gets included in the 3.39.0 release. |
wmdietl
pushed a commit
to eisop/checker-framework
that referenced
this pull request
Oct 18, 2023
Co-authored-by: Michael Ernst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checkers don't crash on the new features, but the new features are not yet soundly checked.
https://openjdk.org/jeps/440
https://openjdk.org/jeps/441
Fixes #6173 and fixes #5967.