Handle zIndex in TJSDialog / move to Position

_dist/application/SvelteApplication.js

@@ -198,16 +198,13 @@ export class SvelteApplication extends Application
    }
 
    /**
-    * Provide an override to set reactive z-index after calling super method.
+    * Provide an override to set this application as the active window regardless of z-index. Changes behaviour from
+    * Foundry core. This is important / used for instance in dialog key handling for left / right button selection.
     */
    bringToTop()
    {
       super.bringToTop();
 
-      const z = document.defaultView.getComputedStyle(this.element[0]).zIndex;
-
-      this.reactive.zIndex = z === 'null' || z === null ? null : parseInt(z, 10);
-
       ui.activeWindow = this;
    }
 

_dist/application/TJSDialog.js

@@ -175,8 +175,8 @@ export class TJSDialog extends SvelteApplication
             modalOptions,
             popOut,
             resizable,
-            zIndex,
             transition,
+            zIndex,
             buttons: deepMerge(mergedButtons, {
                yes: {
                   callback: (html) =>
@@ -287,7 +287,7 @@ export class TJSDialog extends SvelteApplication
  *
  * @property {object}   [transition] - Transition options for the dialog.
  *
- * @property {number|null} [zIndex] - A specific z-index for the dialog. *
+ * @property {number|null} [zIndex] - A specific z-index for the dialog.
  */
 
 /**
@@ -305,7 +305,7 @@ export class TJSDialog extends SvelteApplication
  *
  * @property {boolean}  [rejectClose=false] - Reject the Promise if the Dialog is closed without making a choice.
  *
- * @property {object}   [options={}] - Additional rendering options passed to the Dialog
+ * @property {object}   [options={}] - Additional application options passed to the TJSDialog.
  *
  * @property {boolean}  [draggable=true] - The dialog is draggable when true.
  *
@@ -321,5 +321,5 @@ export class TJSDialog extends SvelteApplication
  *
  * @property {object}   [transition] - Transition options for the dialog.
  *
- * @property {number|null} [zIndex] - A specific z-index for the dialog. *
+ * @property {number|null} [zIndex] - A specific z-index for the dialog.
  */

_dist/application/legacy/SvelteFormApplication.js

@@ -204,16 +204,13 @@ export class SvelteFormApplication extends FormApplication
    }
 
    /**
-    * Provide an override to set reactive z-index after calling super method.
+    * Provide an override to set this application as the active window regardless of z-index. Changes behaviour from
+    * Foundry core. This is important / used for instance in dialog key handling for left / right button selection.
     */
    bringToTop()
    {
       super.bringToTop();
 
-      const z = document.defaultView.getComputedStyle(this.element[0]).zIndex;
-
-      this.reactive.zIndex = z === 'null' || z === null ? null : parseInt(z, 10);
-
       ui.activeWindow = this;
    }
 

src/application/SvelteApplication.js

@@ -198,16 +198,13 @@ export class SvelteApplication extends Application
    }
 
    /**
-    * Provide an override to set reactive z-index after calling super method.
+    * Provide an override to set this application as the active window regardless of z-index. Changes behaviour from
+    * Foundry core. This is important / used for instance in dialog key handling for left / right button selection.
     */
    bringToTop()
    {
       super.bringToTop();
 
-      const z = document.defaultView.getComputedStyle(this.element[0]).zIndex;
-
-      this.reactive.zIndex = z === 'null' || z === null ? null : parseInt(z, 10);
-
       ui.activeWindow = this;
    }
 

src/application/TJSDialog.js

@@ -175,8 +175,8 @@ export class TJSDialog extends SvelteApplication
             modalOptions,
             popOut,
             resizable,
-            zIndex,
             transition,
+            zIndex,
             buttons: deepMerge(mergedButtons, {
                yes: {
                   callback: (html) =>
@@ -287,7 +287,7 @@ export class TJSDialog extends SvelteApplication
  *
  * @property {object}   [transition] - Transition options for the dialog.
  *
- * @property {number|null} [zIndex] - A specific z-index for the dialog. *
+ * @property {number|null} [zIndex] - A specific z-index for the dialog.
  */
 
 /**
@@ -305,7 +305,7 @@ export class TJSDialog extends SvelteApplication
  *
  * @property {boolean}  [rejectClose=false] - Reject the Promise if the Dialog is closed without making a choice.
  *
- * @property {object}   [options={}] - Additional rendering options passed to the Dialog
+ * @property {object}   [options={}] - Additional application options passed to the TJSDialog.
  *
  * @property {boolean}  [draggable=true] - The dialog is draggable when true.
  *
@@ -321,5 +321,5 @@ export class TJSDialog extends SvelteApplication
  *
  * @property {object}   [transition] - Transition options for the dialog.
  *
- * @property {number|null} [zIndex] - A specific z-index for the dialog. *
+ * @property {number|null} [zIndex] - A specific z-index for the dialog.
  */

src/application/legacy/SvelteFormApplication.js

@@ -204,16 +204,13 @@ export class SvelteFormApplication extends FormApplication
    }
 
    /**
-    * Provide an override to set reactive z-index after calling super method.
+    * Provide an override to set this application as the active window regardless of z-index. Changes behaviour from
+    * Foundry core. This is important / used for instance in dialog key handling for left / right button selection.
     */
    bringToTop()
    {
       super.bringToTop();
 
-      const z = document.defaultView.getComputedStyle(this.element[0]).zIndex;
-
-      this.reactive.zIndex = z === 'null' || z === null ? null : parseInt(z, 10);
-
       ui.activeWindow = this;
    }
 

src/component/core/dialog/DialogShell.svelte

@@ -92,7 +92,7 @@
       const newTitle = data.title ?? 'Dialog';
       if (newTitle !== application?.options?.title) { application.reactive.title = newTitle; }
 
-      if (application.reactive.zIndex !== zIndex) { application.reactive.zIndex = zIndex; }
+      if (application.position.zIndex !== zIndex) { application.position.zIndex = zIndex; }
    }
 
    // ApplicationShell transition options ----------------------------------------------------------------------------