Skip to content

Commit

Permalink
8341168: Cleanup dead code after JDK-8322630
Browse files Browse the repository at this point in the history
Reviewed-by: stefank, tschatzl, mli, shade
  • Loading branch information
xmas92 committed Oct 1, 2024
1 parent 1b46fea commit ad5ffcc
Show file tree
Hide file tree
Showing 10 changed files with 4 additions and 38 deletions.
2 changes: 1 addition & 1 deletion src/hotspot/share/code/compiledIC.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ bool CompiledIC::is_monomorphic() const {
}

bool CompiledIC::is_megamorphic() const {
return VtableStubs::entry_point(destination()) != nullptr;;
return VtableStubs::entry_point(destination()) != nullptr;
}

bool CompiledIC::is_speculated_klass(Klass* receiver_klass) {
Expand Down
5 changes: 0 additions & 5 deletions src/hotspot/share/compiler/compilerDefinitions.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -497,11 +497,6 @@ bool CompilerConfig::check_args_consistency(bool status) {
"Invalid NonNMethodCodeHeapSize=%dK. Must be at least %uK.\n", NonNMethodCodeHeapSize/K,
min_code_cache_size/K);
status = false;
} else if (InlineCacheBufferSize > NonNMethodCodeHeapSize / 2) {
jio_fprintf(defaultStream::error_stream(),
"Invalid InlineCacheBufferSize=" SIZE_FORMAT "K. Must be less than or equal to " SIZE_FORMAT "K.\n",
InlineCacheBufferSize/K, NonNMethodCodeHeapSize/2/K);
status = false;
}

#ifdef _LP64
Expand Down
3 changes: 0 additions & 3 deletions src/hotspot/share/runtime/globals.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -289,9 +289,6 @@ const int ObjectAlignmentInBytes = 8;
product(bool, UseInlineCaches, true, \
"Use Inline Caches for virtual calls ") \
\
product(size_t, InlineCacheBufferSize, 10*K, EXPERIMENTAL, \
"InlineCacheBuffer size") \
\
product(bool, InlineArrayCopy, true, DIAGNOSTIC, \
"Inline arraycopy native that is known to be part of " \
"base library DLL") \
Expand Down
4 changes: 1 addition & 3 deletions src/hotspot/share/runtime/mutexLocker.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ Mutex* SharedDictionary_lock = nullptr;
Monitor* ClassInitError_lock = nullptr;
Mutex* Module_lock = nullptr;
Mutex* CompiledIC_lock = nullptr;
Mutex* InlineCacheBuffer_lock = nullptr;
Mutex* VMStatistic_lock = nullptr;
Mutex* JmethodIdCreation_lock = nullptr;
Mutex* JfieldIdCreation_lock = nullptr;
Expand Down Expand Up @@ -262,7 +261,7 @@ void mutex_init() {

MUTEX_DEFN(JfieldIdCreation_lock , PaddedMutex , safepoint);

MUTEX_DEFN(CompiledIC_lock , PaddedMutex , nosafepoint); // locks VtableStubs_lock, InlineCacheBuffer_lock
MUTEX_DEFN(CompiledIC_lock , PaddedMutex , nosafepoint); // locks VtableStubs_lock
MUTEX_DEFN(MethodCompileQueue_lock , PaddedMonitor, safepoint);
MUTEX_DEFN(CompileStatistics_lock , PaddedMutex , safepoint);
MUTEX_DEFN(DirectivesStack_lock , PaddedMutex , nosafepoint);
Expand Down Expand Up @@ -319,7 +318,6 @@ void mutex_init() {
#endif

// These locks have relative rankings, and inherit safepoint checking attributes from that rank.
MUTEX_DEFL(InlineCacheBuffer_lock , PaddedMutex , CompiledIC_lock);
MUTEX_DEFL(VtableStubs_lock , PaddedMutex , CompiledIC_lock); // Also holds DumpTimeTable_lock
MUTEX_DEFL(CodeCache_lock , PaddedMonitor, VtableStubs_lock);
MUTEX_DEFL(NMethodState_lock , PaddedMutex , CodeCache_lock);
Expand Down
1 change: 0 additions & 1 deletion src/hotspot/share/runtime/mutexLocker.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ extern Mutex* SharedDictionary_lock; // a lock on the CDS shared dic
extern Monitor* ClassInitError_lock; // a lock on the class initialization error table
extern Mutex* Module_lock; // a lock on module and package related data structures
extern Mutex* CompiledIC_lock; // a lock used to guard compiled IC patching and access
extern Mutex* InlineCacheBuffer_lock; // a lock used to guard the InlineCacheBuffer
extern Mutex* VMStatistic_lock; // a lock used to guard statistics count increment
extern Mutex* JmethodIdCreation_lock; // a lock on creating JNI method identifiers
extern Mutex* JfieldIdCreation_lock; // a lock on creating JNI static field identifiers
Expand Down
1 change: 0 additions & 1 deletion src/hotspot/share/runtime/thread.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ Thread::Thread(MemTag mem_tag) {
set_handle_area(new (mem_tag) HandleArea(mem_tag, nullptr));
set_metadata_handles(new (mtClass) GrowableArray<Metadata*>(30, mtClass));
set_last_handle_mark(nullptr);
DEBUG_ONLY(_missed_ic_stub_refill_verifier = nullptr);

// Initial value of zero ==> never claimed.
_threads_do_token = 0;
Expand Down
15 changes: 0 additions & 15 deletions src/hotspot/share/runtime/thread.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
class CompilerThread;
class HandleArea;
class HandleMark;
class ICRefillVerifier;
class JvmtiRawMonitor;
class NMethodClosure;
class Metadata;
Expand Down Expand Up @@ -242,20 +241,6 @@ class Thread: public ThreadShadow {
public:
void set_last_handle_mark(HandleMark* mark) { _last_handle_mark = mark; }
HandleMark* last_handle_mark() const { return _last_handle_mark; }
private:

#ifdef ASSERT
ICRefillVerifier* _missed_ic_stub_refill_verifier;

public:
ICRefillVerifier* missed_ic_stub_refill_verifier() {
return _missed_ic_stub_refill_verifier;
}

void set_missed_ic_stub_refill_verifier(ICRefillVerifier* verifier) {
_missed_ic_stub_refill_verifier = verifier;
}
#endif // ASSERT

private:
// Used by SkipGCALot class.
Expand Down
1 change: 0 additions & 1 deletion src/hotspot/share/runtime/vmOperation.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@
template(PrintCompileQueue) \
template(PrintClassHierarchy) \
template(PrintClasses) \
template(ICBufferFull) \
template(PrintMetadata) \
template(GTestExecuteAtSafepoint) \
template(GTestStopSafepoint) \
Expand Down
6 changes: 0 additions & 6 deletions src/hotspot/share/runtime/vmOperations.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,6 @@ class VM_ForceSafepoint: public VM_EmptyOperation {
VMOp_Type type() const { return VMOp_ForceSafepoint; }
};

// empty vm op, when forcing a safepoint due to inline cache buffers being full
class VM_ICBufferFull: public VM_EmptyOperation {
public:
VMOp_Type type() const { return VMOp_ICBufferFull; }
};

class VM_ClearICs: public VM_Operation {
private:
bool _preserve_static_stubs;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ public class StubQueue extends VMObject {
private static CIntegerField queueEndField;
private static CIntegerField numberOfStubsField;

// The type of the contained stubs (i.e., InterpreterCodelet,
// ICStub). Must be a subclass of type Stub.
// The type of the contained stubs (i.e., InterpreterCodelet).
// Must be a subclass of type Stub.
private Class<?> stubType;

static {
Expand Down

0 comments on commit ad5ffcc

Please sign in to comment.