Re-enable staff signouts, Makerstore Link #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PencilAmazing
commented
Dec 4, 2024
•
PencilAmazing
commented
- Enables manual staff sign out using a more direct interface. Properly test sign outs now
- Makerstore links tile is now configurable.
- Login page now properly redirects back to refer(r)er parameter
Gives more control over the display, and hopefully that eases any future transition to a home made storefront
Assumes imagemagick is installed on the server. I know it is required by active storage itself, but I don't think the deployment script installs it. Has to be manual on new server/dev setup
This reverts commit a1c5388.
…king Fix lab session sign out from staff dashboards
…rols Makerstore controls for front page
Properly redirect to the back_to param if set, I'm not quite sure what the whole session cookie thing was but if nothing breaks this is simpler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.