Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MERGE TO PRODUCTION #103

Open
wants to merge 106 commits into
base: main
Choose a base branch
from
Open

MERGE TO PRODUCTION #103

wants to merge 106 commits into from

Conversation

nofamex
Copy link
Contributor

@nofamex nofamex commented Jun 24, 2022

No description provided.

Zsaschz and others added 30 commits March 1, 2022 15:59
* [CHORES] setting up library

* [REFACTOR] remove duplicated and unused files

* [REFACTOR] add newlines and remove dummy data on pages

* [REFACTOR] resolve naming convention and change authors email
* [CHORES] add unit testing for frontend

* [CHORES] add test and coverage pipeline

* [CHORES] fix unit test pipeline

* [CHORES] fix test pipeline

* [CHORES] fix test pipeline

* [CHORES] change test pipeline

* [CHORES] fix test pipeline

* [CHORES] fix comments
* [CHORES] setting up library

* [CHORES] fix js location on templates

* fix conflicts

* [CHORES] fix test setup
FXDROS and others added 28 commits April 5, 2022 01:00
* [RED] Implement Topic

* [REFACTOR] Fix code smell

* [REFACTOR] fix color
* [REFACTOR] hotfix some bugs

* [REFACTOR] move author validation to separate function
* [CHORES] Create layout for create/edit topic, material, assignment, quiz

* [RED] Check if title: Create Material is exist

* [RED] Check if title: Create Material is exist

* [REFACTOR] Remove test

* [RED] Check if topic dropdown is exist

* [RED] Check if title form is exist when loaded

* [RED] Check if description form is exist when loaded

* [RED] Check if cancel button is exist when loaded

* [RED] Check if create button exists when loaded

* [GREEN] Implement all interfaces required

* [RED] Check if back button exist when loaded

* [RED] Check if title exists when loaded

* [RED] Check if divider exists when loaded

* [GREEN] Implement all required interfaces

* [CHORES] Create routes to create material

* [CHORES] Wiring Material menu

* [CHORES] Add id props and use topic from api

* [REFACTOR] Remove extra line and make the hierarchy clearer

* [REFACTOR] Remove unused part
* add coverage

* [GREEN] Fix failing tests

* [CHORES] Add coverage
* [CHORES] Create layout for create/edit topic, material, assignment, quiz

* [RED] Check if title: Create Material is exist

* [RED] Check if title: Create Material is exist

* [REFACTOR] Remove test

* [RED] Check if topic dropdown is exist

* [RED] Check if title form is exist when loaded

* [RED] Check if description form is exist when loaded

* [RED] Check if cancel button is exist when loaded

* [RED] Check if create button exists when loaded

* [GREEN] Implement all interfaces required

* [RED] Check if back button exist when loaded

* [RED] Check if title exists when loaded

* [RED] Check if divider exists when loaded

* [GREEN] Implement all required interfaces

* [CHORES] Create routes to create material

* [CHORES] Wiring Material menu

* [CHORES] Add id props and use topic from api

* [REFACTOR] Remove extra line and make the hierarchy clearer

* [REFACTOR] Remove unused part

* [RED] Check if topic title is given

* [GREEN] Add topic title for materials if topic title is given

* [REFACTOR] change test description

* [RED] Menu should not exists when content type is not given

* [RED] Menu should exists when content type is given

* [GREEN] Implement menu

* [RED] Description should not exists if not given

* [RED] Description should exists when given

* [RED] Change test data

* [GREEN] Implement all required interfaces

* [CHORES] Add routings

* [CHORES] Merge with staging

* [CHORES] Run test

* [CHORES] Add test coverage

* [REFACTOR] Add indentation
* [RED] Implement Topic

* [REFACTOR] Fix code smell

* [REFACTOR] fix color

* [RED] Add Test for Classwork/Topic

* [GREEN] Fix Bug on Test

* [REFACTOR] Fix IDs to match Test

* [REFACTOR] Add new line
* [GREEN] implement upload material content

* [CHORES] generate coverage

* [CHORES] fix conflicts

* [CHORES] fix conflicts

* [REFACTOR] change api file name
* [CHORES] Create layout for create/edit topic, material, assignment, quiz

* [RED] Check if title: Create Material is exist

* [RED] Check if title: Create Material is exist

* [REFACTOR] Remove test

* [RED] Check if topic dropdown is exist

* [RED] Check if title form is exist when loaded

* [RED] Check if description form is exist when loaded

* [RED] Check if cancel button is exist when loaded

* [RED] Check if create button exists when loaded

* [GREEN] Implement all interfaces required

* [RED] Check if back button exist when loaded

* [RED] Check if title exists when loaded

* [RED] Check if divider exists when loaded

* [GREEN] Implement all required interfaces

* [CHORES] Create routes to create material

* [CHORES] Wiring Material menu

* [CHORES] Add id props and use topic from api

* [REFACTOR] Remove extra line and make the hierarchy clearer

* [REFACTOR] Remove unused part

* [RED] Check if topic title is given

* [GREEN] Add topic title for materials if topic title is given

* [REFACTOR] change test description

* [RED] Menu should not exists when content type is not given

* [RED] Menu should exists when content type is given

* [GREEN] Implement menu

* [RED] Description should not exists if not given

* [RED] Description should exists when given

* [RED] Change test data

* [GREEN] Implement all required interfaces

* [CHORES] Add routings

* [CHORES] Merge with staging

* [CHORES] Run test

* [CHORES] Add test coverage

* [REFACTOR] Add indentation

* [CHORES] Implement back and cancel button

* [CHORES] Wiring course creation

* [CHORES] Wiring course materials view

* [CHORES] Resolve conflicts

* [REFACTOR] Change test variable

* [GREEN] Passed all test after merging

* [CHORES] Add coverage reports

* [CHORES] Implement topic title on lesson material

* [CHORES] Change icon alignment

* [REFACTOR] Add props dummy data

* [RED] Check if lesson-material does exist for each topic

* [GREEN] Implement mapping for lesson materials on each topic

* [CHORES] Add coverage report

* [CHORES] Add coverage reports

* [RED] Only teacher/course creator can access create button

* [GREEN] Check if current user is the creator of the course

* [CHORES] Add test coverages

* [RED] Create tests for 404 page

* [GREEN] Implement interface

* [CHORES] Add test coverages

* [REFACTOR] Fix indentation

* [CHORES] Change font-weight

* [CHORES] Implement see lesson material with no topic

* [CHORES] Add coverage reports

* [REFACTOR] Made dateSlicing as a utils function

* [REFACTOR] Remove log

* [REFACTOR] User inertia visit instead of window assign

* [CHORES] Add coverage reports
* [SLICING] FE for Edit Material

* [REFACTOR] Fix attributes convention
* [RED] create test for title

* [RED] change simple test with indexing test

* [GREEN] implement title

* [RED] add check avatar and name test

* [GREEN] implement name and avatar

* [REFACTOR] fix code smell

* Update LMSThemeSetup.php

* [REFACTOR] fix code smell

* [REFACTOR] fix code smell

* [REFACTOR] fix code smell

* [REFACTOR] fix code smell

* [REFACTOR] clean unused code

* [REFACTOR] fix code smell

* [REFACTOR] fix code smell

* [REFACTOR] fix indentation

* [REFACTOR] fix code smell

* [REFACTOR] grouping url and fix indentation

* [REFACTOR] change url

* [RED] create test

* [GREEN] implement class code widget

* [REFACTOR] add test for method

* Fix Typo

* Changed indentation from 4 to 2

* Resolved Code Smell

* [CHORES] sq coverage

* [CHORES] sq coverage

* [CHORES] sq coverage

* [CHORES] changes id name and add some test

* [GREEN] implement create and read comment

* [GREEN] implement read comment

* [REFACTOR] data type and indentation

* [CHORES] update coverage

* change file name

* add new file

* [RED] create test for delete comment

* [GREEN] implement delete comment

* [RED] create test for edit comment

* [GREEN] impelement edit comment

* coverage

* [GREEN] implement create comment

* [GREEN] implement see comment in lesson material

* [REFACTOR] add new line

* [REFACTOR] change dateslicing and snakcbar

* [REFACTOR] add new line

Co-authored-by: Darren Ngoh <[email protected]>
* [GREEN] implement edit comment

* [GREEN] implement only the creator can edit

* [GREEN] implement delete comment for teacher and the creator
* [CHORES] fix conflicts

* [RED] create edit material test

* [GREEN] implement edit course material

* [GREEN] implement delete course material

* [REFACTOR] add file validation before upload

* [CHORES] generate coverage

* [CHORES] remove log
* add coverage

* [CHORES] Resolve conflict

* [CHORES] Slicing submission page

* [CHORES] Slicing submission page

* [REFACTOR] file formatting

* [REFACTOR] file formatting

* [REFACTOR] file formatting

* [CHORES] Add coverage report

* [CHORES] Fix test-report xml
* [RED] add test

* [GREEN] implement create assignment

* [CHORES] add new line
* [RED] add test

* [GREEN] implement create assignment

* [CHORES] add new line

* [RED] add test

* [GREEN] implement view assignment

* [CHORES] update classwork page

* coverage
* [RED] add create quiz testcase

* [GREEN] implement create quiz form

* [CHORES] add page redirect

* [CHORES] fix typo

* [REFACTOR] change date format

* [REFACTOR] change attribute name

* [REFACTOR] add user state on test
* [RED] add create quiz testcase

* [GREEN] implement create quiz form

* [RED] add read quiz test

* [GREEN] implement read quiz

* [REFACTOR] remove date on quiz classwork

* [CHORES] fix conflicts
* add coverage

* [CHORES] Resolve conflict

* [CHORES] Slicing submission page

* [CHORES] Slicing submission page

* [REFACTOR] file formatting

* [REFACTOR] file formatting

* [REFACTOR] file formatting

* [CHORES] Add coverage report

* [CHORES] Fix test-report xml

* [CHORES] Merge with staging

* [CHORES] disabling save button when submission does not exist

* [CHORES] Implement add and see submission

* [CHORES] wiring edit submission

* [REFACTOR] Add spaces between curly braces on import statements

* [REFACTOR] Remove console log
* add details assignment

* [REFACTOR] add space
* add coverage

* [CHORES] Resolve conflict

* [CHORES] Slicing submission page

* [CHORES] Slicing submission page

* [REFACTOR] file formatting

* [REFACTOR] file formatting

* [REFACTOR] file formatting

* [CHORES] Add coverage report

* [CHORES] Fix test-report xml

* [CHORES] Merge with staging

* [CHORES] disabling save button when submission does not exist

* [CHORES] Implement add and see submission

* [CHORES] wiring edit submission

* [REFACTOR] Add spaces between curly braces on import statements

* [REFACTOR] Remove console log

* [CHORES] Disabling form when assignment is overdue

* [CHORES] Add divider

* [CHORES] disabling save/edit button

* [REFACTOR] Simplify string

Co-authored-by: AldiNFitrah <[email protected]>

Co-authored-by: AldiNFitrah <[email protected]>
* wired api endpoint for update and delete

* create new page for edit assignment

* implemented routings for update assignments

* made some adjustment for assignment pages and templates to accodomate different contentType

* fix indentation

* add new line
* [CHORES] fix quiz redirect and date

* [GREEN] implement edit and delete quiz

* [REFACTOR] fix date checking

* [REFACTOR] fix styling for styleci

* [REFACTOR] fix styling for styleci

* [CHORES] remove console log

* [REFACTOR] fix description attribute name

* [REFACTOR] fix description attribute name
* add coverage

* [CHORES] Resolve conflict

* [CHORES] Slicing submission page

* [CHORES] Slicing submission page

* [REFACTOR] file formatting

* [REFACTOR] file formatting

* [REFACTOR] file formatting

* [CHORES] Add coverage report

* [CHORES] Fix test-report xml

* [CHORES] Merge with staging

* [CHORES] disabling save button when submission does not exist

* [CHORES] Implement add and see submission

* [CHORES] wiring edit submission

* [REFACTOR] Add spaces between curly braces on import statements

* [REFACTOR] Remove console log

* [CHORES] Disabling form when assignment is overdue

* [CHORES] Add divider

* [CHORES] disabling save/edit button

* fix slicing and wiring

* add avatar

* fix slicing

* [CHORES] change divider color to primary color

* [CHORES] Resolve review

* [CHORES] Change base color
* [CHORES] remove console log

* [CHORES] update quiz icon in classwork page

* [CHORES] change ava in lesson material comment section

* [CHORES] truncate course name
Copy link
Member

@rizkiheryandi rizkiheryandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about change lms-theme to ilma-theme for better naming consistency ?

}
"laravel": {
"providers": [
"Uasoft\\Badaso\\Theme\\LMSTheme\\Providers\\LMSThemeProvider"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untuk penamaan tema, mungkin bisa disesuaikan dengan nama yang sekarang, sehingga bisa menjadi "Uasoft\Badaso\Theme\Ilma\Providers\BadasoIlmaThemeProvider"

*
* @var string
*/
protected $name = 'badaso-lms-theme:setup';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untuk menyesuakan dengan nama theme, mungki bisa disesuaikan menjadi "badaso-ilma-theme:setup"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants