-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation and Setup #285
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…served log levels and invoke_serverless_function levels.
* Updated benchmarks, and caching created remove clients. * Removed override permission for benchmarks. * Added a unit test for _get_remote_client * linting * Slightly improved benchmarks labeling.
vGsteiger
requested review from
Danidite and
jerryyiransun
and removed request for
Danidite
August 20, 2024 19:05
@vGsteiger README file seems to links to a non-existent contribution guide at the end. |
jerryyiransun
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I've made a few modifications
* Added caching to client CLI * linting * Also modified remove_function instance to also use the cached remote client.
Danidite
added a commit
that referenced
this pull request
Aug 21, 2024
* Fix some parts of the readme * Update documentation * chore: Update documentation and fix some parts of the readme * updated setup documentation * updated readme files * Update poetry * Update quick start and readme * updated naming restrictions. * Added additional restrictions to sourrce_code limitation regarding reserved log levels and invoke_serverless_function levels. * Updated metrics manager with workflow collector and region collector changes. * Remote Client Caching and Benchmark Updates (#288) * Updated benchmarks, and caching created remove clients. * Removed override permission for benchmarks. * Added a unit test for _get_remote_client * linting * Slightly improved benchmarks labeling. * Caribou-Go: Moving Monte-Carlo Simulation to Go (#282) * paper information added * Update QUICK_START.md * move docker installation to INSTALL.md * minor refine documentations * Added caching to client CLI (#295) * Added caching to client CLI * linting * Also modified remove_function instance to also use the cached remote client. * Disabled all deployment package upload to S3 and S3 table creation (#296) * Disabled all deployment package upload to S3 and S3 table creation, fixed issue of deployment_manager crashing IF some region does not possess carbon data. * Fixed small comment mistake. * Patch integration test to still function with this change. * Add contributing * chore: Retry table creation on error * Fix some last docu issues --------- Co-authored-by: pjavanrood <[email protected]> Co-authored-by: Danidite <[email protected]> Co-authored-by: Daniel Long <[email protected]> Co-authored-by: pjavanrood <[email protected]> Co-authored-by: Mohammad Shahrad <[email protected]> Co-authored-by: Jerry Sun <[email protected]> Co-authored-by: Jerry Sun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does the following: