Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Benchmark licenses #323

Merged
merged 9 commits into from
Sep 26, 2024
Merged

Add Benchmark licenses #323

merged 9 commits into from
Sep 26, 2024

Conversation

Danidite
Copy link
Contributor

Closes #322

@engshahrad
Copy link
Contributor

I have not been marked as a reviewer yet. Is there anything left to be done for this PR before I can review @Danidite ? Thanks

@Danidite
Copy link
Contributor Author

I have not been marked as a reviewer yet. Is there anything left to be done for this PR before I can review @Danidite ? Thanks

The only thing missing are licenses for MapReduce and FEM; while I don't think we used any external pieces of code for FEM, I am unsure about MapReduce. @jerryyiransun, can you confirm if either of those benchmarks uses any external code? If so, can you add licenses for them?

@Danidite Danidite self-assigned this Sep 24, 2024
@Danidite Danidite requested a review from engshahrad September 24, 2024 20:55
@jerryyiransun
Copy link
Collaborator

I have not been marked as a reviewer yet. Is there anything left to be done for this PR before I can review @Danidite ? Thanks

The only thing missing are licenses for MapReduce and FEM; while I don't think we used any external pieces of code for FEM, I am unsure about MapReduce. @jerryyiransun, can you confirm if either of those benchmarks uses any external code? If so, can you add licenses for them?

The MapReduce and FEM benchmarks did not use any external code, so no need to add licenses for them

@jerryyiransun jerryyiransun marked this pull request as ready for review September 24, 2024 20:56
Copy link

github-actions bot commented Sep 24, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
caribou/common
   utils.py37878%43–58
caribou/common/models/remote_client
   aws_remote_client.py5247186%43, 66, 68, 108, 154, 219, 222, 258, 275–276, 326–327, 365, 376, 386, 419–421, 429–430, 449–451, 470, 473, 497, 510–511, 514, 520, 560–562, 600–602, 620–621, 662, 668, 678, 682, 693–694, 702–703, 712, 716, 727, 737–739, 759, 770–772, 792, 807–809, 824–829, 857–858, 862, 878–882, 888–889, 904–905
   remote_client_factory.py21386%21–23
caribou/data_collector/components
   data_collector.py18194%23
   data_exporter.py34294%49, 56
caribou/data_collector/components/carbon
   carbon_collector.py21290%34–35
   carbon_retriever.py1341887%25, 59, 93, 135–144, 148, 153, 160, 168–169, 215, 246, 249, 256
caribou/data_collector/components/performance
   performance_retriever.py38684%44, 50–51, 56–59
caribou/data_collector/components/provider
   provider_collector.py24292%43–44
   provider_retriever.py2975382%24, 32, 34, 47, 59, 77, 84, 100, 132–156, 187–285, 303–308, 340, 348, 350, 352, 354, 356, 358, 360, 436, 450, 560, 653
caribou/data_collector/components/workflow
   workflow_collector.py25196%34
   workflow_retriever.py30510964%216–257, 280, 330–337, 339, 371–414, 436, 467–526, 533–563, 566–583, 587–604, 615, 676, 698
caribou/data_collector/utils/latency_retriever
   aws_latency_retriever.py74988%59, 63, 65, 67, 70, 74, 76, 78, 81
   latency_retriever.py6183%8
caribou/deployment/client
   caribou.py16194%22
   caribou_workflow.py46513571%54, 70–71, 80–83, 129, 201–223, 267–268, 282, 315–326, 347–354, 380–391, 434–454, 562, 578, 581, 636–662, 667–683, 705–715, 793, 796, 798, 800, 802, 804, 831, 866–881, 916–917, 927–931, 961, 996, 1004, 1016–1096, 1109–1138, 1172–1181, 1212, 1245, 1273–1282, 1302–1320, 1340, 1353–1359, 1365
caribou/deployment/client/remote_cli
   remote_cli_handler.py91910%1–146
caribou/deployment/common/config
   config.py83199%104
caribou/deployment/common/deploy
   deployer.py1401689%43, 102–109, 199, 240–242, 249, 256, 267
   deployment_packager.py2374780%31, 34, 39, 63–70, 73–84, 90, 96, 101, 106, 128, 156, 169, 182, 190, 251–253, 262, 275, 328–343, 353, 355, 357, 360
   executor.py53492%32–33, 66, 68
   workflow_builder.py1711392%43, 59, 146, 178, 186, 189, 191, 196, 205, 208, 210, 324, 330
caribou/deployment/common/deploy/models
   function.py42295%42, 53
   function_instance.py12283%16, 22
   iam_role.py34391%19–21
   instructions.py18289%17, 26
   resource.py18194%25
   workflow.py1943284%39, 44, 67, 77, 99, 120, 166, 171, 206, 219–231, 272, 281, 289, 293, 298–327
caribou/deployment/common/deploy_instructions
   aws_deploy_instructions.py24292%37, 83
   deploy_instructions.py54983%57, 95, 145, 151, 164, 168, 172, 176, 182
caribou/deployment/common/factories
   deploy_instruction_factory.py18383%20–22
   deployer_factory.py1061685%23–26, 40, 51–52, 81, 89, 98, 107, 118, 125–128
caribou/deployment/server
   re_deployment_server.py61592%36, 48, 51, 58, 107
caribou/deployment_solver
   workflow_config.py751185%24, 26, 32–33, 54–56, 61, 79, 82, 107
caribou/deployment_solver/deployment_algorithms
   coarse_grained_deployment_algorithm.py29293%33, 38
   deployment_algorithm.py1001189%54, 95, 111, 124, 138, 155, 190–196, 225
   fine_grained_deployment_algorithm.py29293%44, 49
   stochastic_heuristic_deployment_algorithm.py1021585%20–28, 54, 57, 83, 98, 109, 112, 117, 123–126, 136, 153, 180, 187
caribou/deployment_solver/deployment_input
   input_manager.py1995572%126, 132, 135, 194, 200, 246–254, 276–282, 291–294, 304–307, 320–339, 352–373, 379–387, 441–442, 476–487, 493–495, 501
caribou/deployment_solver/deployment_input/components/calculators
   carbon_calculator.py96496%124–128, 214, 261
   cost_calculator.py70199%163
   runtime_calculator.py1091190%130–145, 152, 201, 209, 262, 295
caribou/deployment_solver/deployment_input/components/loaders
   carbon_loader.py21386%22, 43, 46
   datacenter_loader.py49590%106–111, 114
   performance_loader.py18194%38
   region_viability_loader.py17288%15, 32
   workflow_loader.py1472682%86, 102–112, 122, 145, 165, 183, 193, 210, 264–276, 292, 364–369, 392, 430–432, 437
caribou/deployment_solver/deployment_metrics_calculator
   deployment_metrics_calculator.py40198%49
   go_deployment_metrics_calculator.py543241%21, 25–28, 32–34, 48–57, 60, 71–83, 86–90, 93–95, 98–99
   simple_deployment_metrics_calculator.py1291787%125–142, 170–171, 203–204, 220–223, 235–236, 251
caribou/deployment_solver/deployment_metrics_calculator/models
   workflow_instance.py1948258%84–95, 107, 141–144, 183–186, 194–196, 203–227, 238–269, 275–289, 308–441, 520
caribou/deployment_solver/models
   indexer.py17194%25
caribou/deployment_solver/ranker
   ranker.py62494%14, 26–27, 95
caribou/endpoint
   client.py1412185%50, 60, 110, 120, 142–145, 156, 187, 203, 205, 243–247, 252–253, 257–260
caribou/monitors
   deployment_manager.py1351887%65, 71, 82, 101, 123–128, 164–169, 184, 207, 222, 228, 263, 283
   monitor.py8188%12
caribou/syncers
   log_sync_workflow.py52129044%108, 163–173, 178, 186, 193, 203, 210, 248–254, 256, 258, 260, 262, 264, 268, 272, 274, 276, 279–285, 288, 292, 302–369, 378–385, 395–463, 472–475, 480–495, 506–597, 610–664, 674–700, 705–722, 727–744, 758, 765–788, 797–798, 808, 813–819, 846–847, 849–850, 855–856, 890–897, 901, 938, 940, 945, 979, 983–986, 994–1004, 1007–1013, 1016–1027, 1030
   log_syncer.py42198%46
caribou/syncers/components
   execution_data.py74495%76, 86, 129, 137
   workflow_run_sample.py83693%136, 145–149
TOTAL6655129880% 

Tests Skipped Failures Errors Time
665 0 💤 0 ❌ 0 🔥 23.901s ⏱️

Copy link
Contributor

@engshahrad engshahrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks

@engshahrad engshahrad merged commit e5f60a7 into main Sep 26, 2024
7 checks passed
@engshahrad engshahrad deleted the benchmark_licenses branch September 26, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add benchmark licenses
3 participants