Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Home Regions and other Regions Config to Objects #43

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

vGsteiger
Copy link
Collaborator

Close #42

@vGsteiger vGsteiger added this to the Initial Benchmark milestone Jan 9, 2024
@vGsteiger vGsteiger requested a review from Danidite January 9, 2024 00:23
@vGsteiger vGsteiger self-assigned this Jan 9, 2024
Copy link

github-actions bot commented Jan 9, 2024

✅ Result of Pytest Coverage

---------- coverage: platform linux, python 3.10.12-final-0 ----------

Name Stmts Miss Cover

~ 54 passed in 2.30s ~

@vGsteiger vGsteiger changed the title Refactor enum names and update provider regions Change Home Regions and other Regions Config to Objects Jan 9, 2024
Copy link
Contributor

@Danidite Danidite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I will apply the change to the solver super class.

@vGsteiger vGsteiger merged commit c6f345a into main Jan 9, 2024
5 checks passed
@vGsteiger vGsteiger deleted the features/vgs/change_home_regions_config branch January 9, 2024 19:50
Danidite pushed a commit that referenced this pull request Jan 12, 2024
* Refactor enum names and update provider regions

* Update region configuration in app.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change home regions config to dictionary instead of list (fake tuple)
2 participants