Features/jerry/function level env #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you have two merge conflicts, let me know if you need any help resolving those. |
|
Also please usually add a comment "closes #22" to the description, this will let GitHub know that it should link the issue with the PR to close it subsequently. |
vGsteiger
reviewed
Jan 10, 2024
vGsteiger
reviewed
Jan 10, 2024
vGsteiger
reviewed
Jan 10, 2024
multi_x_serverless/deployment/client/deploy/workflow_builder.py
Outdated
Show resolved
Hide resolved
vGsteiger
approved these changes
Jan 11, 2024
✅ Result of Pytest Coverage |
Danidite
pushed a commit
that referenced
this pull request
Jan 12, 2024
* completed draft for function level env var * completed func level env variable + added new tests * fix issues * Remove test_workflow_builder_func_env_var.py and fix tests --------- Co-authored-by: vgsteiger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #22
added new test
multi_x_serverless/tests/deployment/client/deploy/test_workflow_builder_func_env_var.pyand modified existing test for the new feature. Changed "name" to "key" in the config file for conventionadded explanation of the new feature in the design.md file