Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parrotfish for Step Function, Execution Time Constraint Optimization #164

Merged
merged 12 commits into from
Aug 28, 2024
Merged

Parrotfish for Step Function, Execution Time Constraint Optimization #164

merged 12 commits into from
Aug 28, 2024

Conversation

zyangbi
Copy link
Contributor

@zyangbi zyangbi commented Aug 26, 2024

No description provided.

@arshiamoghimi arshiamoghimi self-requested a review August 27, 2024 02:26
arshiamoghimi
arshiamoghimi requested changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@arshiamoghimi arshiamoghimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But please add some test cases to cover the critical path calculations and the execution time constraint suggestion

@arshiamoghimi arshiamoghimi self-requested a review August 28, 2024 00:38
@arshiamoghimi arshiamoghimi merged commit 0c8a2f6 into ubc-cirrus-lab:master Aug 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arshiamoghimi arshiamoghimi arshiamoghimi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zyangbi @arshiamoghimi