Add support for running tests inside container

WIP, there are still some tests failing. Need more investigation.

docker-compose.yaml

@@ -16,6 +16,7 @@ services:
       context: .
     expose:
       - 9000
+    container_name: hotcrp
     restart: always
     volumes:
       - ./docker/msmtprc:/etc/msmtprc

docker/README.md

@@ -33,3 +33,25 @@ Keycloak:
 MariaDB:
 * Root: `root`/`root`
 * HotCRP: `hotcrp`/`hotcrppwd`
+
+Tests
+-----
+
+To run tests in container, follow the steps below:
+```bash
+# create a port forwarding in hotcrp container to mysql as some of the places for db host are hardcoded as localhost
+docker run --rm --name mysql-bridge --net=container:hotcrp alpine/socat TCP-LISTEN:3306,fork TCP:mysql:3306
+
+# enter to the hotcrp container
+docker exec -it hotcrp bash
+
+# install db client
+apt update && apt install -y mariadb-client procps
+
+# create databases, users and schemas. use 127.0.0.1 to trigger mysql client to use tcp instead of socket and grant hotcrp.% host privileges.
+lib/createdb.sh -u root -proot -c test/options.php --batch  --host 127.0.0.1 --grant-host hotcrp.% --replace
+lib/createdb.sh -u root -proot -c test/cdb-options.php --no-dbuser --batch  --host 127.0.0.1 --grant-host hotcrp.% --replace
+
+# run the tests
+test/check.sh --all
+```

lib/createdb.sh

@@ -50,7 +50,7 @@ set_dbuserpass () {
 }
 
 add_granthost () {
-    if expr "$1" : '[-a-zA-Z0-9.*][-a-zA-Z0-9.*]*$' >/dev/null; then
+    if expr "$1" : '^[.%_a-zA-Z0-9-]*$' >/dev/null; then
         granthosts="$granthosts $1"
     else
         echo "Expected --grant-host=HOSTNAME" 1>&2

test/cdb-options.php

@@ -5,6 +5,7 @@
 $Opt["dbName"] = "hotcrp_testdb_cdb";
 $Opt["dbUser"] = "hotcrp_testdb";
 $Opt["dbPassword"] = "m5LuaN23j26g";
+$Opt["dbHost"] = "127.0.0.1";
 $Opt["shortName"] = "Testconf I";
 $Opt["longName"] = "Test Conference I";
 $Opt["contactName"] = "Eddie Kohler";

test/options.php

@@ -4,6 +4,7 @@
 global $Opt;
 $Opt["dbName"] = "hotcrp_testdb";
 $Opt["dbPassword"] = "m5LuaN23j26g";
+$Opt["dbHost"] = "127.0.0.1";
 $Opt["shortName"] = "Testconf I";
 $Opt["longName"] = "Test Conference I";
 $Opt["paperSite"] = "http://hotcrp.lcdf.org/test/";
@@ -16,6 +17,6 @@
 $Opt["smartScoreCompare"] = true;
 $Opt["timezone"] = "America/New_York";
 $Opt["postfixEOL"] = "\n";
-$Opt["contactdbDsn"] = "mysql://hotcrp_testdb:m5LuaN23j26g@localhost/hotcrp_testdb_cdb";
+$Opt["contactdbDsn"] = "mysql://hotcrp_testdb:m5LuaN23j26g@127.0.0.1/hotcrp_testdb_cdb";
 $Opt["obsoletePasswordInterval"] = 1;
 $Opt["include"][] = "?test/localoptions.php";