Skip to content

Commit

Permalink
Remove a filter in getMixevalResultDetail
Browse files Browse the repository at this point in the history
The filter was based on primary role which is incorrect. It should be
based on course role.
  • Loading branch information
xcompass committed Dec 15, 2015
1 parent 9dceb35 commit 4eae6dd
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions app/controllers/components/evaluation.php
Original file line number Diff line number Diff line change
Expand Up @@ -1078,9 +1078,9 @@ function getMixevalResultDetail($groupEventId, $groupMembers, $include)
$userId = isset($user['User'])? $user['User']['id'] : $user['id'];

// filter out the people who are not student, they should not get result
if ($user['Role'][0]['name'] != 'student') {
continue;
}
// if ($user['Role'][0]['name'] != 'student') {
// continue;
// }

// get the results for students
$evalResult[$userId] = $this->EvaluationMixeval->getResultsByEvaluatee($groupEventId, $userId, $include);
Expand Down

0 comments on commit 4eae6dd

Please sign in to comment.