Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Flake8 rules #28

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

Update Flake8 rules #28

wants to merge 20 commits into from

Conversation

RodneyCodess
Copy link

@RodneyCodess RodneyCodess commented Jun 24, 2024

Note: This PR is based on #26. The diff between them can be viewed here.

Description

This PR makes changes to .github/workflows/python-package.yml and docs/developing.md for style errors.

  • The PR adds in additional Flake8 packages to detect and fix more style errors, more specifically quotes and comma errors.

  • The PR updates .github/workflows/python-package.yml to add in the additional Flake8 packages to check for the errors we couldn't see before.

  • The PR adds additional steps to download the new packages, Flake8-commas and Flake8-quotes for detecting the comma and quote errors.

Tests performed

Once we installed the new packages Flake8-commas and Flake8-quotes we kept running flake8 tests until we fixed all style errors detected by the packages.

Types of changes

  • Refactoring / documentation update (non-breaking change which does not change functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • CHANGELOG.md has been updated
  • The milestone is set correctly on the pull request
  • The appropriate labels have been added to the pull request
  • Running the automated tests (see docs/developing.md) produces no errors
  • Updates have been made to the xdmod-notebooks repository as necessary, and the notebooks all run successfully

@aaronweeden aaronweeden added this to the 1.1.0 milestone Jun 24, 2024
@aaronweeden aaronweeden added qa/testing Updates/additions to tests and removed qa/testing Updates/additions to tests labels Jun 24, 2024
@aaronweeden aaronweeden modified the milestones: 1.1.0, 2.0.0 Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants