forked from jpwhite4/xdmod-python
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Flake8 rules #28
Draft
RodneyCodess
wants to merge
20
commits into
ubccr:main
Choose a base branch
from
RodneyCodess:flake8
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit df1f00e.
Co-authored-by: Aaron Weeden <[email protected]>
aaronweeden
added
qa/testing
Updates/additions to tests
and removed
qa/testing
Updates/additions to tests
labels
Jun 24, 2024
aaronweeden
reviewed
Jun 24, 2024
aaronweeden
reviewed
Jun 24, 2024
aaronweeden
reviewed
Jun 24, 2024
Co-authored-by: Aaron Weeden <[email protected]>
Co-authored-by: Aaron Weeden <[email protected]>
Co-authored-by: Aaron Weeden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is based on #26. The diff between them can be viewed here.
Description
This PR makes changes to
.github/workflows/python-package.yml
anddocs/developing.md
for style errors.The PR adds in additional Flake8 packages to detect and fix more style errors, more specifically quotes and comma errors.
The PR updates
.github/workflows/python-package.yml
to add in the additional Flake8 packages to check for the errors we couldn't see before.The PR adds additional steps to download the new packages,
Flake8-commas
andFlake8-quotes
for detecting the comma and quote errors.Tests performed
Once we installed the new packages
Flake8-commas
andFlake8-quotes
we kept running flake8 tests until we fixed all style errors detected by the packages.Types of changes
Checklist:
CHANGELOG.md
has been updateddocs/developing.md
) produces no errorsxdmod-notebooks
repository as necessary, and the notebooks all run successfully