-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose gopatch API as patch package #181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Abhinav Gupta <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
==========================================
+ Coverage 87.30% 87.41% +0.11%
==========================================
Files 39 40 +1
Lines 2457 3267 +810
==========================================
+ Hits 2145 2856 +711
- Misses 251 343 +92
- Partials 61 68 +7 ☔ View full report in Codecov by Sentry. |
It seems that the normal code is all covered by the tests. |
I think the missing error lines are fine as-is. You may want to rename patch.PatchFile to just patch.File. |
Thanks for the PR! I will take a look at this some time later tonight. |
thanks! I updated that abhinav's suggestion. |
@sywhang PTAL 🙏 (It's Monday evening in my time zone, but it might have been Sunday night there. Sorry!) |
closes #94
Expose gopatch API with minimal API.