another test

uber · Dec 19, 2024 · 1a1c042 · 1a1c042
1 parent 6a32c6a
commit 1a1c042
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/nullaway/src/main/java/com/uber/nullaway/NullAway.java b/nullaway/src/main/java/com/uber/nullaway/NullAway.java
@@ -490,7 +490,6 @@ public Description matchAssignment(AssignmentTree tree, VisitorState state) {
       // assigning to symbol that is unannotated
       return Description.NO_MATCH;
     }
-    // TODO add test that we skip generics check if lhs symbol is unannotated
     // generics check
     if (lhsType != null && config.isJSpecifyMode()) {
       GenericsChecks.checkTypeParameterNullnessForAssignability(tree, this, state);

diff --git a/nullaway/src/test/java/com/uber/nullaway/jspecify/GenericsTests.java b/nullaway/src/test/java/com/uber/nullaway/jspecify/GenericsTests.java
@@ -2045,6 +2045,30 @@ public void issue1093() {
         .doTest();
   }
 
+  @Test
+  public void nullUnmarkedGenericField() {
+    makeHelper()
+        .addSourceLines(
+            "Test.java",
+            "package com.unannotated;",
+            "import org.jspecify.annotations.*;",
+            "import java.util.function.Function;",
+            "public class Test {",
+            "  static Function<@Nullable String, @Nullable String> foo;",
+            "  @NullMarked",
+            "  static class Inner {",
+            "    static @Nullable Function<@Nullable String, @Nullable String> bar;",
+            "    void bar(Function<String,String> f) {",
+            "      // no error since foo is in @NullUnmarked code",
+            "      foo = f;",
+            "      // BUG: Diagnostic contains: Cannot assign from type Function<String, String>",
+            "      bar = f;",
+            "    }",
+            "  }",
+            "}")
+        .doTest();
+  }
+
   private CompilationTestHelper makeHelper() {
     return makeTestHelperWithArgs(
         Arrays.asList(