Code

Support @EnsuresNonNullIf#1044

Code

Merged

msridhar merged 53 commits intouber:masteruber/NullAway:masterfrom mauricioaniche:ensures-non-null-ifmauricioaniche/NullAway:ensures-non-null-ifCopy head branch name to clipboardSep 30, 2024

+1,447-76

Commits

Commits on Sep 24, 2024

• First draft of @EnsuresNonNullIf

  mauricioaniche

  committed
  60c09cd

• Merge branch 'master' into ensures-non-null-if

  mauricioaniche

  authored
  dfcfb04

Commits on Sep 25, 2024

• Improve validation of the semantics of the EnsuresNonNullIfHandler

  mauricioaniche

  committed
  c674bf9

• More tests

  mauricioaniche

  committed
  c511a79

• Improve docs

  mauricioaniche

  committed
  9eac416

• Validate post-conditions in child classes

  mauricioaniche

  committed
  38d6d88

• A few more tests

  mauricioaniche

  committed
  c2a5dc2

• Tests cleanup

  mauricioaniche

  committed
  17b9173

• Fix error message in FieldContractUtils

  mauricioaniche

  committed
  e4ab9ba

• Fix error message in FieldContractUtils again

  mauricioaniche

  committed
  9cbcf4e

• Add trueIfNonNull to invert the result of the EnsuresNonNullIf method

  mauricioaniche

  committed
  d044fae

• Throw exception instead of returning default value in exceptional case

  mauricioaniche

  committed
  d700ee3

• Rename variable

  mauricioaniche

  committed
  6842120

• Fix nullability issues in my code

  mauricioaniche

  committed
  df1293f

• One more test

  mauricioaniche

  committed
  1bf794c

• Move ignored tests to the bottom

  mauricioaniche

  committed
  c471082

Commits on Sep 26, 2024

• add TODO

  msridhar

  committed
  6ebac11

Commits on Sep 27, 2024

• Make use of internal state to get the enclosing method of a return tree

  mauricioaniche

  committed
  3b27dae

• Improvements here and there

  mauricioaniche

  committed
  4aa9ed0

Commits on Sep 28, 2024

• New approach

  mauricioaniche

  committed
  c0a70ac

• Code review feedback

  mauricioaniche

  committed
  5f2ad31

• Nit on javadoc

  mauricioaniche

  committed
  3ad3944

• Nit in comments

  mauricioaniche

  committed
  3afb836

• Put class back to original state to reduce changes in PR

  mauricioaniche

  committed
  de81671

Commits on Sep 29, 2024

• Got it working

  mauricioaniche

  committed
  92b3a77

• Cleaning up the doc and more docs

  mauricioaniche

  committed
  04a7d42

• Fix clean up

  mauricioaniche

  committed
  ee32c48

• More fixes

  mauricioaniche

  committed
  81b1edc

• Rename trueIfNonNull to result and make it compulsory, to match CheckerFramework

  mauricioaniche

  committed
  fbd05a7

• More cleanups

  mauricioaniche

  committed
  b1faf00

• Handle missing case where allFieldsInPathAreVerified is false and evaluatesToLiteral

  mauricioaniche

  committed
  0f71fde

• nit comment

  mauricioaniche

  committed
  880ae42

• one more test

  mauricioaniche

  committed
  f478ac4

• one more test

  mauricioaniche

  committed
  d53958b

• FIX typo name of the test

  mauricioaniche

  committed
  13b0cca

• FIX typo name of the test

  mauricioaniche

  committed
  5d8157d

• one more test

  mauricioaniche

  committed
  2623bfa

• Fix nullaway issues in nullaway

  mauricioaniche

  committed
  1b1967c

Commits on Sep 30, 2024

• JSpecify annotation

  mauricioaniche

  committed
  80ef2ca

• small refactoring; fix compilation

  mauricioaniche

  committed
  5428602

• Use elseStore when result is set to false

  mauricioaniche

  committed
  ca7a54a

• Set return default value to true again

  mauricioaniche

  committed
  bb139df

• Improve tests

  mauricioaniche

  committed
  f23a8d4

• test for error message when result=false

  mauricioaniche

  committed
  45907e1

• Return true in case body is null just like existing EnsureNonNull handler

  mauricioaniche

  committed
  7a3d075

• simplify error message

  mauricioaniche

  committed
  3c7295e

• Broken test

  mauricioaniche

  committed
  2bbbac2

• Fix issue when return=false and method returns boolean

  mauricioaniche

  committed
  ea10969

• Let's not use an Optional here. Since we check the code with NullAway, using null should be fine

  msridhar

  committed
  3cb7d51

• No need to report when all paths are verified but return is wrong

  mauricioaniche

  committed
  56a0984

• minor comment tweak

  msridhar

  committed
  f98fb3c

• simplify dataflow update logic

  msridhar

  committed
  fa7728e

• comments

  msridhar

  committed
  1c5610c