Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some Android astubx models #1052

Merged
merged 6 commits into from
Oct 7, 2024

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented Oct 6, 2024

Update SDKs 28-30 as our astubx format has changed. SDK 31 to come in a follow-up PR. Also add a minimal integration test to ensure things aren't completely broken (at least for one SDK model version, which typically should be the latest one).

Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.61%. Comparing base (69b8e4c) to head (c77c4a3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1052      +/-   ##
============================================
+ Coverage     87.54%   87.61%   +0.07%     
  Complexity     2165     2165              
============================================
  Files            85       85              
  Lines          7114     7114              
  Branches       1386     1386              
============================================
+ Hits           6228     6233       +5     
+ Misses          458      452       -6     
- Partials        428      429       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msridhar msridhar merged commit 4eaf484 into uber:master Oct 7, 2024
11 checks passed
@msridhar msridhar deleted the update-some-android-astubx branch October 7, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants