Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment positions #1098

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Fix comment positions #1098

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions nullaway/src/main/java/com/uber/nullaway/NullabilityUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,8 +346,7 @@ private static boolean targetTypeMatches(Symbol sym, TypeAnnotationPosition posi
case LOCAL_VARIABLE:
return position.type == TargetType.LOCAL_VARIABLE;
case FIELD:
// treated like a field
case ENUM_CONSTANT:
case ENUM_CONSTANT: // treated like a field
return position.type == TargetType.FIELD;
case CONSTRUCTOR:
case METHOD:
Expand All @@ -367,8 +366,7 @@ private static boolean targetTypeMatches(Symbol sym, TypeAnnotationPosition posi
return false;
}
case CLASS:
// treated like a class
case ENUM:
case ENUM: // treated like a class
// There are no type annotations on the top-level type of the class/enum being declared,
// only on other types in the signature (e.g. `class Foo extends Bar<@A Baz> {}`).
return false;
Expand Down
Loading