Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report error for @Nullable synchronized block expression #1106

Merged
merged 6 commits into from
Dec 22, 2024

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented Dec 21, 2024

Fixes #1103

The Caffeine JMH benchmark now fails due to the new checking; we will update in a follow-up (#1108)

@msridhar msridhar marked this pull request as draft December 21, 2024 22:10
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.11%. Comparing base (d0502e8) to head (325daa3).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...away/src/main/java/com/uber/nullaway/NullAway.java 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1106      +/-   ##
============================================
+ Coverage     88.10%   88.11%   +0.01%     
- Complexity     2209     2212       +3     
============================================
  Files            84       84              
  Lines          7179     7188       +9     
  Branches       1426     1428       +2     
============================================
+ Hits           6325     6334       +9     
+ Misses          430      429       -1     
- Partials        424      425       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msridhar msridhar marked this pull request as ready for review December 22, 2024 12:26
@msridhar msridhar enabled auto-merge (squash) December 22, 2024 18:13
@msridhar msridhar merged commit 2754c45 into master Dec 22, 2024
11 checks passed
@msridhar msridhar deleted the 2024-12-21-synchronized-deref branch December 22, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

synchronized should be considered a dereference
2 participants