Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build latest Caffeine on CI #1111

Merged
merged 7 commits into from
Dec 23, 2024
Merged

Build latest Caffeine on CI #1111

merged 7 commits into from
Dec 23, 2024

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented Dec 22, 2024

Fixes #1110

We can see how this goes for some time before making it a required job.

Copy link

codecov bot commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.12%. Comparing base (f2bafb2) to head (b786307).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1111   +/-   ##
=========================================
  Coverage     88.12%   88.12%           
  Complexity     2221     2221           
=========================================
  Files            84       84           
  Lines          7197     7197           
  Branches       1430     1430           
=========================================
  Hits           6342     6342           
  Misses          430      430           
  Partials        425      425           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msridhar msridhar changed the title [WIP] Caffeine CI job Build latest Caffeine on CI Dec 23, 2024
@msridhar msridhar marked this pull request as ready for review December 23, 2024 14:02
@yuxincs
Copy link
Collaborator

yuxincs commented Dec 23, 2024

This is pretty cool!

BTW we have a similar job in NilAway that posts the diff of diagnostics produced by NilAway on stdlib on HEAD vs main for each PR: https://github.com/uber-go/nilaway/blob/main/.github/workflows/golden-test-run.yml

Example: uber-go/nilaway#281 (comment)

We have generally found this to be very useful (although it's partly because NilAway is less mature)

@msridhar
Copy link
Collaborator Author

This is pretty cool!

BTW we have a similar job in NilAway that posts the diff of diagnostics produced by NilAway on stdlib on HEAD vs main for each PR: https://github.com/uber-go/nilaway/blob/main/.github/workflows/golden-test-run.yml

Example: uber-go/nilaway#281 (comment)

We have generally found this to be very useful (although it's partly because NilAway is less mature)

Very cool! I think once this bakes a bit we could implement some similar logic here. We would just have to grep out the NullAway warnings from the Gradle build output, though possibly we could just use NullAway's serialization support (thus far used only for NullAway Annotator) to make things more robust.

@msridhar msridhar merged commit 728bf77 into master Dec 23, 2024
12 checks passed
@msridhar msridhar deleted the caffeine-ci-job branch December 23, 2024 14:55
@ben-manes
Copy link

ben-manes commented Dec 23, 2024

We would just have to grep out the NullAway warnings from the Gradle build output

You can use problem-matcher.json to annotate the pr. Caffeine’s build should fail unless you decide to mark the gha step as continue-on-error.

@msridhar
Copy link
Collaborator Author

We would just have to grep out the NullAway warnings from the Gradle build output

You can use problem-matcher.json to annotate the pr.

Very cool! From what I'm reading, problem matchers help to annotate source code in the PR. But here, we have a PR on NullAway, and the errors / warnings we would be looking for would be reported on Caffeine's code. Would this approach still work?

Caffeine’s build should fail unless you decide to mark the gha step as continue-on-error.

Ah ok, so NullAway is running at error level now, cool! That makes things easier, we can just look for a job failure.

@ben-manes
Copy link

Would this approach still work?

I believe it would simply be unlinked to the file but still be an annotation attached to the pr. It might look like the ones you have currently wrt the pending ubuntu upgrade.

Screenshot 2024-12-23 at 2 12 23 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up a CI job testing with Caffeine
3 participants