Make AbstractConfig collection fields explicity Immutable #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazaroclapp
commented
May 13, 2022
| /** | ||
| * if true, {@link #fromAnnotatedPackage(Symbol.ClassSymbol)} will return false for any class | ||
| * annotated with {@link javax.annotation.Generated} | ||
| */ |
There was a problem hiding this comment.
No other such protected field has docs and besides these are stale (#fromAnnotatedPackage for this class no longer exists, it was never only that annotation, and after #600 this isn't even only [simple-name] @Generated), so...
lazaroclapp
commented
May 13, 2022
| @@ -296,15 +292,15 @@ public boolean isContractAnnotation(String annotationName) { | |||
| return contractAnnotations.contains(annotationName); | |||
| } | |||
|
|
|||
| protected Set<MethodClassAndName> getKnownInitializers(Set<String> qualifiedNames) { | |||
| protected ImmutableSet<MethodClassAndName> getKnownInitializers(Set<String> qualifiedNames) { | |||
There was a problem hiding this comment.
Note this is called only once during config loading in ErrorProneCLIFlagsConfig
Pull Request Test Coverage Report for Build #954
💛 - Coveralls |
This is a re-do, from scratch of a very stale PR.
lazaroclapp
force-pushed
the
lazaro_nullaway_change_config_sets_to_immutable
branch
from
7df44b4 to
9fbea32
Compare
msridhar
approved these changes
Sep 13, 2022
lazaroclapp
deleted the
lazaro_nullaway_change_config_sets_to_immutable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #600. These values are already
ImmutableSetat runtime(except one which was still used strictly as read-only). This change just
makes it explicit.