Ignore incompatibly annotated var args from Kotlin code. #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build #1041
💛 - Coveralls |
lazaroclapp
commented
Jan 25, 2023
| " Utilities.takesNullableVarargs(o1, o4);", | ||
| " Utilities.takesNullableVarargs(o1, (java.lang.Object) null);", | ||
| // SHOULD be an error! | ||
| " Utilities.takesNullableVarargs(o1, (java.lang.Object[]) null);", |
There was a problem hiding this comment.
Turns out there is a way to pass null varargs array from Java 😅
There was a problem hiding this comment.
Ah, interesting. Didn't think of this one
msridhar
approved these changes
Jan 26, 2023
| " Utilities.takesNullableVarargs(o1, o4);", | ||
| " Utilities.takesNullableVarargs(o1, (java.lang.Object) null);", | ||
| // SHOULD be an error! | ||
| " Utilities.takesNullableVarargs(o1, (java.lang.Object[]) null);", |
There was a problem hiding this comment.
Ah, interesting. Didn't think of this one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #720 for a detailed explanation.
Long story short:
kotlincwill add@org.jetbrains.annotations.NotNullas a declaration annotation for any argument that is non-null, which we pick up from jars when running withAcknowledgeRestrictiveAnnotations=true.open fun w(vararg args: Any?)as having@NotNull args(meaning the array itself).w(@NotNull Object... args), which we believe should be interpreted as marking the elements ofargsas being@NotNull.RestrictiveAnnotationHandlerto skip@org.jetbrains.annotations.NotNullon var args only.Additionally, our basic handling of var args is pretty broken. I went over our test cases and commented where I think our current behavior is different from the desired behavior as documented in #720 and #674. Foregoing fixing it for now, as I am worried about the breaking change and I think we want to avoid changing that before 0.10.9.