Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly check generic method overriding in explicitly-typed anonymous classes #808

Merged
merged 94 commits into from
Sep 29, 2023

link issue and add static import

26085c4
Select commit
Loading
Failed to load commit list.
Merged

Properly check generic method overriding in explicitly-typed anonymous classes #808

link issue and add static import
26085c4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 29, 2023 in 0s

86.75% (-0.05%) compared to 7d8cd4a

View this Pull Request on Codecov

86.75% (-0.05%) compared to 7d8cd4a

Details

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (7d8cd4a) 86.79% compared to head (26085c4) 86.75%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #808      +/-   ##
============================================
- Coverage     86.79%   86.75%   -0.05%     
- Complexity     1870     1876       +6     
============================================
  Files            74       74              
  Lines          6178     6197      +19     
  Branches       1202     1206       +4     
============================================
+ Hits           5362     5376      +14     
- Misses          405      408       +3     
- Partials        411      413       +2     
Files Coverage Δ
...away/src/main/java/com/uber/nullaway/NullAway.java 89.68% <100.00%> (ø)
...rc/main/java/com/uber/nullaway/GenericsChecks.java 89.65% <86.36%> (-0.32%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.