Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply minor cleanups suggested by IntelliJ in generics code #860

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented Nov 15, 2023

Remove unnecessary casts, switch to isEmpty() in a couple of places, fix a typo. No behavior changes, just cleanup

@msridhar msridhar enabled auto-merge (squash) November 15, 2023 02:45
@msridhar msridhar requested a review from yuxincs November 15, 2023 02:45
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9092438) 87.02% compared to head (c549ea9) 87.02%.

Files Patch % Lines
...ava/com/uber/nullaway/generics/GenericsChecks.java 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #860      +/-   ##
============================================
- Coverage     87.02%   87.02%   -0.01%     
  Complexity     1921     1921              
============================================
  Files            77       77              
  Lines          6219     6218       -1     
  Branches       1209     1209              
============================================
- Hits           5412     5411       -1     
  Misses          403      403              
  Partials        404      404              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@yuxincs yuxincs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@msridhar msridhar merged commit 4b6e672 into uber:master Nov 15, 2023
9 of 10 checks passed
@msridhar msridhar deleted the generics-cleanup branch November 15, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants