Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model Apache Flink's RichFunction.open as an @Initializer method #862

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

lazaroclapp
Copy link
Collaborator

From the docs here: open(...) should always be called before other methods,
such as filter(...), so it fits our definition of an @Initializer method.

@lazaroclapp lazaroclapp changed the title Library Model for RichFunction.open as an @Initializer method Model Apache Flink's RichFunction.open as an @Initializer method Nov 16, 2023
@lazaroclapp
Copy link
Collaborator Author

lazaroclapp commented Nov 16, 2023

@msridhar let me know if you'd want a test case here. Would mean adding Apache Flink as a test dependency and there isn't really any new code path being tested, though (also, we are simultaneously making this patch as internal config at Uber while we wait for the next release here, will add you to the diff)

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9092438) 87.02% compared to head (370cf08) 87.02%.
Report is 1 commits behind head on master.

Files Patch % Lines
...ava/com/uber/nullaway/generics/GenericsChecks.java 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #862      +/-   ##
============================================
- Coverage     87.02%   87.02%   -0.01%     
  Complexity     1921     1921              
============================================
  Files            77       77              
  Lines          6219     6218       -1     
  Branches       1209     1209              
============================================
- Hits           5412     5411       -1     
  Misses          403      403              
  Partials        404      404              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lazaroclapp lazaroclapp requested a review from msridhar November 16, 2023 19:55
Copy link
Collaborator

@msridhar msridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok without a test for this one, though if possible it'd be good to do some kind of local sanity test (even just on the config is fine)

@msridhar msridhar merged commit 01aa34e into master Nov 17, 2023
9 of 10 checks passed
@msridhar msridhar deleted the lazaro_support_rich_function_open branch November 17, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants