Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSpecify: changes for issue #861 #863

Merged

Conversation

akulk022
Copy link
Collaborator

@akulk022 akulk022 commented Nov 18, 2023

Removing unnecessary checks performed for ClassType in GenericChecks.java in reference to issue #861. Added some null checks since some of the checks for ClassType were also indirectly checking for nullability and hence removing them entirely cause the test rawTypes to crash.

Fixes #861

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (eb2e19c) 87.05% compared to head (f3b8129) 87.06%.

Files Patch % Lines
...ava/com/uber/nullaway/generics/GenericsChecks.java 30.00% 0 Missing and 7 partials ⚠️
...r/nullaway/generics/CompareNullabilityVisitor.java 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #863   +/-   ##
=========================================
  Coverage     87.05%   87.06%           
- Complexity     1923     1924    +1     
=========================================
  Files            77       77           
  Lines          6221     6225    +4     
  Branches       1208     1209    +1     
=========================================
+ Hits           5416     5420    +4     
  Misses          403      403           
  Partials        402      402           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msridhar msridhar marked this pull request as ready for review December 5, 2023 21:32
@msridhar msridhar enabled auto-merge (squash) December 5, 2023 21:33
@msridhar msridhar merged commit 2f1cf7c into uber:master Dec 5, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In generics code, get rid of checks for ClassType
2 participants