Fix assertion check for structure of enhanced-for loop over a Map keySet #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #868 +/- ##
============================================
+ Coverage 87.02% 87.04% +0.02%
Complexity 1922 1922
============================================
Files 77 77
Lines 6219 6221 +2
Branches 1210 1208 -2
============================================
+ Hits 5412 5415 +3
- Misses 403 404 +1
+ Partials 404 402 -2 ☔ View full report in Codecov by Sentry. |
|
The test coverage failure is expected here as we do not expect the exceptional cases to actually occur |
|
@yuxincs @lazaroclapp could one of you review? |
msridhar
changed the title
yuxincs
reviewed
Nov 27, 2023
Comment on lines
645
to
646
| && ASTHelpers.isSubtype( | ||
| ASTHelpers.getReceiverType(invocationTree), containingTypeSupplier.get(state), state); |
There was a problem hiding this comment.
This is pretty subtle, do we want to add a comment here stating that symbol.owner.type won't work for certain compilers?
yuxincs
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #866
Before, we would check that an enhanced-for loop includes a call to
Set.iterator()on the result of callingMap.keySet(). However, it is possible and legal that statically, the target of this call is insteadCollection.iterator(). So, we change our check to test the receiver type passed into the call (which must still be aSet). Also, opportunistically switch a couple of places we were throwingRuntimeExceptionaround this check to throw the more meaningfulVerifyException. Unfortunately, we have not found a way to add a test in open-source to reproduce the failure from #866 but we have confirmed this change fixes the problem.