Fix jarinfer cli output determinism #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviernotteghem
force-pushed
the
fix_determinism
branch
from
30208f6 to
055e9d2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #884 +/- ##
============================================
+ Coverage 87.03% 87.09% +0.05%
- Complexity 1926 1940 +14
============================================
Files 77 77
Lines 6231 6267 +36
Branches 1212 1218 +6
============================================
+ Hits 5423 5458 +35
Misses 405 405
- Partials 403 404 +1 ☔ View full report in Codecov by Sentry. |
msridhar
requested changes
Dec 21, 2023
Comment on lines
227
to
229
| ZipEntry entry = new ZipEntry(jarEntry.getName()); | ||
| entry.setTime(0); | ||
| jarOS.putNextEntry(entry); |
There was a problem hiding this comment.
Can we extract these lines to a common private method and call it from all four places? And, in that method, can we add a comment as to why we do entry.setTime(0)?
oliviernotteghem
force-pushed
the
fix_determinism
branch
from
055e9d2 to
ea0fa4b
Compare
msridhar
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When invoking CLI, jar output sha is not constant. This breaks cacheability in build systems like Buck and Bazel.
Binary investigation (see attached screenshot) of these jars show byte 0xa-0xd in PkZip header is what is changes, and corresponds to file modified date/time (see https://users.cs.jmu.edu/buchhofp/forensics/formats/pkzip.html).
This PR is setting these times to 0 explicilty, so that jar sha remains constant between invokation.